Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2864383002: Rename Distance.* file to DistanceEffect.* (Closed)

Created:
3 years, 7 months ago by Raymond Toy
Modified:
3 years, 7 months ago
Reviewers:
Nico, hongchan
CC:
chromium-reviews, haraken, blink-reviews, kinuko+watch, Raymond Toy, hongchan
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename Distance.* file to DistanceEffect.* The class is named DistanceEffect, but the implementation is in the files Distance.{h,cpp}. Rename the file to match the class name. No other changes. BUG=718967 TEST=no changes to tests Review-Url: https://codereview.chromium.org/2864383002 Cr-Commit-Position: refs/heads/master@{#470401} Committed: https://chromium.googlesource.com/chromium/src/+/27ea3538fa4f74eef95f7f53834231aa6c0892c9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -181 lines) Patch
M third_party/WebKit/Source/modules/webaudio/PannerNode.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/platform/audio/Distance.h View 1 chunk +0 lines, -81 lines 0 comments Download
D third_party/WebKit/Source/platform/audio/Distance.cpp View 1 chunk +0 lines, -93 lines 0 comments Download
A + third_party/WebKit/Source/platform/audio/DistanceEffect.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + third_party/WebKit/Source/platform/audio/DistanceEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (7 generated)
Raymond Toy
PTAL
3 years, 7 months ago (2017-05-08 16:58:31 UTC) #2
hongchan
lgtm
3 years, 7 months ago (2017-05-08 20:37:10 UTC) #3
Raymond Toy
thakis: PTAL at BUILD.gn
3 years, 7 months ago (2017-05-08 20:59:18 UTC) #5
Nico
lgtm
3 years, 7 months ago (2017-05-08 21:00:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2864383002/1
3 years, 7 months ago (2017-05-08 21:08:20 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/421114)
3 years, 7 months ago (2017-05-09 01:20:50 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2864383002/1
3 years, 7 months ago (2017-05-09 14:45:40 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-05-09 19:13:50 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/27ea3538fa4f74eef95f7f538342...

Powered by Google App Engine
This is Rietveld 408576698