Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 2864363006: Add smoke test coverage for tracing metrics of measurePageLoad method (Closed)

Created:
3 years, 7 months ago by nednguyen
Modified:
3 years, 7 months ago
Reviewers:
Xianzhu
CC:
chromium-reviews, blink-reviews, telemetry-reviews_chromium.org, kouhei (in TOK)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add smoke test coverage for tracing metrics of measurePageLoad method BUG=chromium:701059 Review-Url: https://codereview.chromium.org/2864363006 Cr-Commit-Position: refs/heads/master@{#470820} Committed: https://chromium.googlesource.com/chromium/src/+/b2241be90f651f59eff4e0d5e0cad45d0743c997

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+380 lines, -0 lines) Patch
A third_party/WebKit/PerformanceTests/TestData/resources/simple.html View 1 chunk +343 lines, -0 lines 0 comments Download
A third_party/WebKit/PerformanceTests/TestData/simple-html-measure-page-load-time.html View 1 chunk +14 lines, -0 lines 0 comments Download
M tools/perf/benchmarks/blink_perf_unittest.py View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 31 (20 generated)
nednguyen
3 years, 7 months ago (2017-05-09 19:28:05 UTC) #2
Xianzhu
lgtm
3 years, 7 months ago (2017-05-09 21:22:32 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2864363006/1
3 years, 7 months ago (2017-05-09 22:11:23 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; ...
3 years, 7 months ago (2017-05-10 00:14:44 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2864363006/1
3 years, 7 months ago (2017-05-10 10:27:25 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/449919)
3 years, 7 months ago (2017-05-10 12:33:08 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2864363006/1
3 years, 7 months ago (2017-05-10 12:56:17 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/450036)
3 years, 7 months ago (2017-05-10 14:59:16 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2864363006/1
3 years, 7 months ago (2017-05-10 21:06:41 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2864363006/1
3 years, 7 months ago (2017-05-11 00:46:11 UTC) #28
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 05:27:08 UTC) #31
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b2241be90f651f59eff4e0d5e0ca...

Powered by Google App Engine
This is Rietveld 408576698