Adds UMA for days since previous use to help us determine the validity

Adds UMA for days since previous use to help us determine the validity
of older address profiles. Older address profiles are not used in
the current checkout flow (i.e. within 15 minutes of form submission).
However, if none of the address profiles were modified/used within
15 minutes of submission, we could extend candidate profiles to older
address profiles depending on the distribution of this new metric.

BUG=719272
Review-Url: https://codereview.chromium.org/2864363004
Cr-Commit-Position: refs/heads/master@{#470614}
Committed: https://chromium.googlesource.com/chromium/src/+/a587a0931dc5dcf00b26d7bb9d1bcb0fe12882c6

[csashi, 2017-05-08 21:07:51]

csashi@google.com changed reviewers:
+ jsaul@google.com, rkaplow@chromium.org, sebsg@chromium.org

[csashi, 2017-05-08 21:07:52]

Hi,
Please take a look. Thanks!
-sashi.

[csashi, 2017-05-08 21:08:56]

The CQ bit was checked by csashi@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-08 21:10:29]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sebsg, 2017-05-08 21:43:30]

Sweet! Some small comments

https://codereview.chromium.org/2864363004/diff/1/components/autofill/core/br...
File components/autofill/core/browser/autofill_manager_unittest.cc (right):

https://codereview.chromium.org/2864363004/diff/1/components/autofill/core/br...
components/autofill/core/browser/autofill_manager_unittest.cc:5926: /*
expected_count= */ 1);
nit: /*expected_count=*/1. That makes sure they will always be on the same line.

https://codereview.chromium.org/2864363004/diff/1/components/autofill/core/br...
File components/autofill/core/browser/autofill_profile.h (right):

https://codereview.chromium.org/2864363004/diff/1/components/autofill/core/br...
components/autofill/core/browser/autofill_profile.h:179: // use and updates
|previous_use_date_| to time it was previously used.
nit: and updates |previous_use_date_| to the last value of |use_date_|/

https://codereview.chromium.org/2864363004/diff/1/components/autofill/core/br...
components/autofill/core/browser/autofill_profile.h:234: base::Time
previous_use_date_;
Could you add a comment here, saying that this value is not preserved when
Chrome is closed?

https://codereview.chromium.org/2864363004/diff/1/components/autofill/core/br...
components/autofill/core/browser/autofill_profile.h:236: RecordType
record_type_;
Is there a particular reason why you moved it down?

[csashi, 2017-05-08 21:51:41]

Hi Sebastien,
Please take a look. Thanks!
-sashi.

https://codereview.chromium.org/2864363004/diff/1/components/autofill/core/br...
File components/autofill/core/browser/autofill_manager_unittest.cc (right):

https://codereview.chromium.org/2864363004/diff/1/components/autofill/core/br...
components/autofill/core/browser/autofill_manager_unittest.cc:5926: /*
expected_count= */ 1);
On 2017/05/08 21:43:29, sebsg wrote:
> nit: /*expected_count=*/1. That makes sure they will always be on the same
line.

Done.

https://codereview.chromium.org/2864363004/diff/1/components/autofill/core/br...
File components/autofill/core/browser/autofill_profile.h (right):

https://codereview.chromium.org/2864363004/diff/1/components/autofill/core/br...
components/autofill/core/browser/autofill_profile.h:179: // use and updates
|previous_use_date_| to time it was previously used.
On 2017/05/08 21:43:29, sebsg wrote:
> nit: and updates |previous_use_date_| to the last value of |use_date_|/

Done.

https://codereview.chromium.org/2864363004/diff/1/components/autofill/core/br...
components/autofill/core/browser/autofill_profile.h:234: base::Time
previous_use_date_;
On 2017/05/08 21:43:29, sebsg wrote:
> Could you add a comment here, saying that this value is not preserved when
> Chrome is closed?

Done.

https://codereview.chromium.org/2864363004/diff/1/components/autofill/core/br...
components/autofill/core/browser/autofill_profile.h:236: RecordType
record_type_;
On 2017/05/08 21:43:29, sebsg wrote:
> Is there a particular reason why you moved it down?

https://bugs.chromium.org/p/chromium/issues/detail?id=710933
This is not an issue for this struct because we have very few profiles - still,
when we can improve padding why not?

[csashi, 2017-05-08 21:52:21]

The CQ bit was checked by csashi@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-08 21:53:39]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sebsg, 2017-05-08 21:54:19]

lgtm

https://codereview.chromium.org/2864363004/diff/1/components/autofill/core/br...
File components/autofill/core/browser/autofill_profile.h (right):

https://codereview.chromium.org/2864363004/diff/1/components/autofill/core/br...
components/autofill/core/browser/autofill_profile.h:236: RecordType
record_type_;
On 2017/05/08 21:51:41, csashi wrote:
> On 2017/05/08 21:43:29, sebsg wrote:
> > Is there a particular reason why you moved it down?
> 
> https://bugs.chromium.org/p/chromium/issues/detail?id=710933
> This is not an issue for this struct because we have very few profiles -
still,
> when we can improve padding why not?

Ah sweet, thank for the info.

[commit-bot: I haz the power, 2017-05-08 22:52:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 22:52:57]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[csashi, 2017-05-08 23:07:21]

On 2017/05/08 21:54:19, sebsg wrote:
> lgtm
> 
>
https://codereview.chromium.org/2864363004/diff/1/components/autofill/core/br...
> File components/autofill/core/browser/autofill_profile.h (right):
> 
>
https://codereview.chromium.org/2864363004/diff/1/components/autofill/core/br...
> components/autofill/core/browser/autofill_profile.h:236: RecordType
> record_type_;
> On 2017/05/08 21:51:41, csashi wrote:
> > On 2017/05/08 21:43:29, sebsg wrote:
> > > Is there a particular reason why you moved it down?
> > 
> > https://bugs.chromium.org/p/chromium/issues/detail?id=710933
> > This is not an issue for this struct because we have very few profiles -
> still,
> > when we can improve padding why not?
> 
> Ah sweet, thank for the info.

Hi Robert,
Please approve for histograms.xml. Thanks! 
-sashi.

[csashi, 2017-05-09 17:37:45]

The CQ bit was checked by csashi@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-09 17:38:41]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 18:53:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-09 18:53:55]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Jared Saul, 2017-05-09 18:59:14]

lgtm

[csashi, 2017-05-09 19:36:07]

On 2017/05/09 18:59:14, Jared Saul wrote:
> lgtm

Hi Robert,
Can you please approve tools/metrics/histograms. Thanks!
-sashi.

[csashi, 2017-05-09 20:21:24]

The CQ bit was checked by csashi@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-09 20:22:15]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 00:43:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 00:43:35]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[rkaplow, 2017-05-10 14:45:05]

lgtm

[csashi, 2017-05-10 16:08:34]

The CQ bit was checked by csashi@google.com

[csashi, 2017-05-10 16:08:34]

The patchset sent to the CQ was uploaded after l-g-t-m from sebsg@chromium.org,
jsaul@google.com
Link to the patchset: https://codereview.chromium.org/2864363004/#ps60001
(title: "Merge forward.")

[commit-bot: I haz the power, 2017-05-10 16:09:31]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 16:54:44]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1494432514028270,
"parent_rev": "040110f9160613190f81f6bc67ef48bbd8594b38", "commit_rev":
"a587a0931dc5dcf00b26d7bb9d1bcb0fe12882c6"}

[commit-bot: I haz the power, 2017-05-10 16:54:54]

Description was changed from

==========
Adds UMA for days since previous use to help us determine the validity
of older address profiles. Older address profiles are not used in
the current checkout flow (i.e. within 15 minutes of form submission).
However, if none of the address profiles were modified/used within
15 minutes of submission, we could extend candidate profiles to older
address profiles depending on the distribution of this new metric.

BUG=719272
==========

to

==========
Adds UMA for days since previous use to help us determine the validity
of older address profiles. Older address profiles are not used in
the current checkout flow (i.e. within 15 minutes of form submission).
However, if none of the address profiles were modified/used within
15 minutes of submission, we could extend candidate profiles to older
address profiles depending on the distribution of this new metric.

BUG=719272

Review-Url: https://codereview.chromium.org/2864363004
Cr-Commit-Position: refs/heads/master@{#470614}
Committed:
https://chromium.googlesource.com/chromium/src/+/a587a0931dc5dcf00b26d7bb9d1b...
==========

[commit-bot: I haz the power, 2017-05-10 16:54:55]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/a587a0931dc5dcf00b26d7bb9d1b...