Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(889)

Issue 2864363003: Add nacl_loader_manifest to mash's catalog. (Closed)

Created:
3 years, 7 months ago by Hadi
Modified:
3 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add nacl_loader_manifest to mash's catalog. This is to make NaCl input method extensions (e.g. Chinese Pinyin input method) work in --mash. BUG=719468 Review-Url: https://codereview.chromium.org/2864363003 Cr-Commit-Position: refs/heads/master@{#470161} Committed: https://chromium.googlesource.com/chromium/src/+/9367844905d7607830db16535e072939175064c6

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed feedback. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/app/mash/BUILD.gn View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
Hadi
PTAL. Thanks.
3 years, 7 months ago (2017-05-08 13:49:49 UTC) #4
sky
https://codereview.chromium.org/2864363003/diff/1/chrome/app/mash/BUILD.gn File chrome/app/mash/BUILD.gn (right): https://codereview.chromium.org/2864363003/diff/1/chrome/app/mash/BUILD.gn#newcode93 chrome/app/mash/BUILD.gn:93: if (enable_nacl) { Should this only happen for chromeos? ...
3 years, 7 months ago (2017-05-08 15:59:31 UTC) #7
Hadi
https://codereview.chromium.org/2864363003/diff/1/chrome/app/mash/BUILD.gn File chrome/app/mash/BUILD.gn (right): https://codereview.chromium.org/2864363003/diff/1/chrome/app/mash/BUILD.gn#newcode93 chrome/app/mash/BUILD.gn:93: if (enable_nacl) { On 2017/05/08 15:59:31, sky wrote: > ...
3 years, 7 months ago (2017-05-08 18:05:05 UTC) #10
sky
LGTM
3 years, 7 months ago (2017-05-08 21:26:14 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2864363003/20001
3 years, 7 months ago (2017-05-09 00:19:00 UTC) #15
commit-bot: I haz the power
3 years, 7 months ago (2017-05-09 03:46:10 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9367844905d7607830db16535e07...

Powered by Google App Engine
This is Rietveld 408576698