Issue 2864353003: Disabling flaky unit test.

Issue 2864353003: Disabling flaky unit test. (Closed)

Created:
3 years, 7 months ago by iclelland

Modified:
3 years, 7 months ago

Reviewers:
Tom Anderson

CC:
chromium-reviews, Peter Beverloo, mlamouri+watch-notifications_chromium.org, awdf+watch_chromium.org

Target Ref:
refs/heads/master

Project:
chromium

Visibility:
Public.

Disabling flaky unit test. The test is marked as triggering a data race by TSAN occasionally (8 builds of the most recent 50). Disabling as flaky. BUG=719485 TBR=thomasanderson@chromium.org Review-Url: https://codereview.chromium.org/2864353003 Cr-Commit-Position: refs/heads/master@{#469985} Committed: https://chromium.googlesource.com/chromium/src/+/ddc4e027e9532bede5216ac3288eee5bd582ed08

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	chrome/browser/notifications/notification_platform_bridge_linux_unittest.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 6 (3 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2864353003/1

3 years, 7 months ago (2017-05-08 14:19:05 UTC) #2

commit-bot: I haz the power

Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/ddc4e027e9532bede5216ac3288eee5bd582ed08

3 years, 7 months ago (2017-05-08 15:07:52 UTC) #5

Tom Anderson

3 years, 7 months ago (2017-05-08 17:58:04 UTC) #6

Message was sent while issue was closed.

lgtm

Are there any flakes on NotificationPlatformBridgeLinuxTest.SetUpAndTearDown?