Issue 28643002: Experimental parser: Small fixes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 28643002: Experimental parser: Small fixes. (Closed)

Created:
7 years, 2 months ago by marja

Modified:
7 years, 2 months ago

Reviewers:
ulan

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/experimental/parser

Visibility:
Public.

More Reviews

Description

Experimental parser: Small fixes. - Endless loops with erroneous strings (we still don't recover like the baseline scanner does). - Identifier cannot start right after a number. - Efficiency: reserve a reasonably big buffer for tokens. - Style fixes BUG= R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17261

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -36 lines)			Patch
	M	src/lexer/lexer.re	View	1	8 chunks	+25 lines, -24 lines	0 comments	Download
	M	src/lexer/lexer-shell.cc	View	1 2	4 chunks	+16 lines, -12 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

marja

7 years, 2 months ago (2013-10-18 09:01:41 UTC) #2

Message was sent while issue was closed.

Committed patchset #4 manually as r17261 (presubmit successful).

Expand Messages | Collapse Messages