[DevTools] Expose TCP targets config in frontend, use it for Node

[DevTools] Expose TCP targets config in frontend, use it for Node

This patch:
- plumbs tcp targets config (shown in inspect ui) to frontend;
- renders that next to port forwarding config;
- reuses that config to discover node instances in node frontend;
- adds "Connection" panel to node frontend.

BUG=706916
Review-Url: https://codereview.chromium.org/2864263002
Cr-Commit-Position: refs/heads/master@{#470379}
Committed: https://chromium.googlesource.com/chromium/src/+/97e8089cd3fde75e259620213a1e02a1d4f29b35

[dgozman, 2017-05-08 17:07:45]

Description was changed from

==========
[DevTools] Expose TCP targets config in frontend, use it for Node

This patch:
- plumbs tcp targets config (shown in inspect ui) to frontend;
- renders that next to port forwarding config;
- reuses that config to discover node instances in node frontend;
- adds "Connect" link to node frontend which opens the drawer view.

BUG=none
==========

to

==========
[DevTools] Expose TCP targets config in frontend, use it for Node

This patch:
- plumbs tcp targets config (shown in inspect ui) to frontend;
- renders that next to port forwarding config;
- reuses that config to discover node instances in node frontend;
- adds "Connect" link to node frontend which opens the drawer view.

BUG=706916
==========

[dgozman, 2017-05-08 17:56:10]

dgozman@chromium.org changed reviewers:
+ pfeldman@chromium.org

[dgozman, 2017-05-08 17:56:11]

Could you please take a look? There is a screenshot in the bug.

[pfeldman, 2017-05-08 18:38:07]

lgtm

https://codereview.chromium.org/2864263002/diff/20001/chrome/browser/devtools...
File chrome/browser/devtools/devtools_ui_bindings.cc (right):

https://codereview.chromium.org/2864263002/diff/20001/chrome/browser/devtools...
chrome/browser/devtools/devtools_ui_bindings.cc:953: std::string javascript =
"DevToolsAPI.devicesDiscoveryConfigChanged(";
Dictionary it, no backwards support needed.

[dgozman, 2017-05-08 20:10:36]

Description was changed from

==========
[DevTools] Expose TCP targets config in frontend, use it for Node

This patch:
- plumbs tcp targets config (shown in inspect ui) to frontend;
- renders that next to port forwarding config;
- reuses that config to discover node instances in node frontend;
- adds "Connect" link to node frontend which opens the drawer view.

BUG=706916
==========

to

==========
[DevTools] Expose TCP targets config in frontend, use it for Node

This patch:
- plumbs tcp targets config (shown in inspect ui) to frontend;
- renders that next to port forwarding config;
- reuses that config to discover node instances in node frontend;
- adds "Connection" panel to node frontend.

BUG=706916
==========

[dgozman, 2017-05-08 20:10:43]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-08 20:11:46]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dgozman, 2017-05-08 20:13:09]

dgozman@chromium.org changed reviewers:
+ tsepez@chromium.org

[dgozman, 2017-05-08 20:13:10]

Tom, could you please take a look at devtools_embedder_message_dispatcher? We
now pass a list of endpoint addresses in addition to port-forwarding
addresses+ports. This is also configurable through chrome://inspect.

Thanks,
Dmitry

[Tom Sepez, 2017-05-08 20:32:04]

On 2017/05/08 20:13:10, dgozman wrote:
> Tom, could you please take a look at devtools_embedder_message_dispatcher? We
> now pass a list of endpoint addresses in addition to port-forwarding
> addresses+ports. This is also configurable through chrome://inspect.
> 
> Thanks,
> Dmitry

So the flow is browser->devtools front end for display?

[commit-bot: I haz the power, 2017-05-08 21:58:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 21:58:58]

Dry run: This issue passed the CQ dry run.

[dgozman, 2017-05-08 22:26:34]

On 2017/05/08 20:32:04, Tom Sepez wrote:
> On 2017/05/08 20:13:10, dgozman wrote:
> > Tom, could you please take a look at devtools_embedder_message_dispatcher?
We
> > now pass a list of endpoint addresses in addition to port-forwarding
> > addresses+ports. This is also configurable through chrome://inspect.
> > 
> > Thanks,
> > Dmitry
> 
> So the flow is browser->devtools front end for display?

Nope, the data comes from devtools to browser and is used to locate remote
debugging targets. Previously this data went through remote debugging protocol,
now it has migrated to "devtools<->embedder" channel instead.

[Tom Sepez, 2017-05-09 16:07:57]

lgtm

[dgozman, 2017-05-09 17:42:10]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2017-05-09 17:42:11]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/2864263002/#ps40001
(title: "panel")

[commit-bot: I haz the power, 2017-05-09 17:43:23]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 18:02:10]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494351730804200,
"parent_rev": "92c2596899bdc46ca42c44027cc152c947a349e1", "commit_rev":
"97e8089cd3fde75e259620213a1e02a1d4f29b35"}

[commit-bot: I haz the power, 2017-05-09 18:02:25]

Description was changed from

==========
[DevTools] Expose TCP targets config in frontend, use it for Node

This patch:
- plumbs tcp targets config (shown in inspect ui) to frontend;
- renders that next to port forwarding config;
- reuses that config to discover node instances in node frontend;
- adds "Connection" panel to node frontend.

BUG=706916
==========

to

==========
[DevTools] Expose TCP targets config in frontend, use it for Node

This patch:
- plumbs tcp targets config (shown in inspect ui) to frontend;
- renders that next to port forwarding config;
- reuses that config to discover node instances in node frontend;
- adds "Connection" panel to node frontend.

BUG=706916

Review-Url: https://codereview.chromium.org/2864263002
Cr-Commit-Position: refs/heads/master@{#470379}
Committed:
https://chromium.googlesource.com/chromium/src/+/97e8089cd3fde75e259620213a1e...
==========

[commit-bot: I haz the power, 2017-05-09 18:02:27]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/97e8089cd3fde75e259620213a1e...