Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Issue 2864243006: [Merge M59] arc: Prevent overwriting of the Chrome Play Store icon. (Closed)

Created:
3 years, 7 months ago by khmel
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

[Merge M59] arc: Prevent overwriting of the Chrome Play Store icon. This implement correct access to ARC icon from notification manager and from ARC kiosk handler. Incorrect access to the Play Store icon caused request to extract this app icon from ARC side and which finally overwrote Chrome Play Store icon, which was not expected. TEST=Manually, Ensure that Play Store notification icon (in notification settings) correctly loaded with Chrome version of Play Store. Also checked arc.app icon cache to confirm that Android version of Play Store icon did not exist there. BUG=719118 TBR=xiyuan@chromium.org,yoshiki@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2865813002 Cr-Commit-Position: refs/heads/master@{#470058} (cherry picked from commit 832d8b7c8aff004eb7480fd0d20ce0508b24d7f4) Review-Url: https://codereview.chromium.org/2864243006 Cr-Commit-Position: refs/branch-heads/3071@{#483} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/8e5c1b368019c5b223a0f201c5405308bf1fa393

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -31 lines) Patch
M chrome/browser/chromeos/app_mode/arc/arc_kiosk_app_service.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/notifications/arc_application_notifier_source_chromeos.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_icon.h View 3 chunks +20 lines, -22 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_icon.cc View 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2864243006/1
3 years, 7 months ago (2017-05-09 18:31:01 UTC) #4
commit-bot: I haz the power
3 years, 7 months ago (2017-05-09 18:32:21 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8e5c1b368019c5b223a0f201c540...

Powered by Google App Engine
This is Rietveld 408576698