Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2864033003: Blink rename follow-up: Rename remaining |m_...| field names in LayoutObject. (Closed)

Created:
3 years, 7 months ago by Łukasz Anforowicz
Modified:
3 years, 7 months ago
Reviewers:
Stephen Chennney, Nico
CC:
chromium-reviews, pdr+renderingwatchlist_chromium.org, zoltan1, blink-reviews-layout_chromium.org, szager+layoutwatch_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Blink rename follow-up: No more |m_...| field names in ADD_BOOLEAN_BITFIELD. It was impossible for the clang-based renaming tool to rename identifiers where the renamed identifier was crossing boundaries of macro token##concatenation - this left some fields named using the |m_oldBlinkStyle|. This CL tweaks the ADD_BOOLEAN_BITFIELD macro, so that it uses new_style_ field names rather than m_oldStyle names. I've also tweaked some comments to refer to the new names. This CL has been mostly generated semi-automatically with the help of editor macros. No intended behavior change. BUG=675877 Review-Url: https://codereview.chromium.org/2864033003 Cr-Commit-Position: refs/heads/master@{#470447} Committed: https://chromium.googlesource.com/chromium/src/+/932bc10e78854ff0191e9e6b0afa8bf0b370c419

Patch Set 1 #

Patch Set 2 : Fixing similar issue in InlineBox.h #

Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -146 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutObject.h View 9 chunks +118 lines, -114 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/InlineBox.h View 1 3 chunks +32 lines, -32 lines 0 comments Download

Messages

Total messages: 19 (15 generated)
Łukasz Anforowicz
schenney@, could you PTAL?
3 years, 7 months ago (2017-05-05 22:38:00 UTC) #10
Nico
lgtm
3 years, 7 months ago (2017-05-08 15:03:06 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2864033003/20001
3 years, 7 months ago (2017-05-09 15:03:24 UTC) #16
commit-bot: I haz the power
3 years, 7 months ago (2017-05-10 04:08:50 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/932bc10e78854ff0191e9e6b0afa...

Powered by Google App Engine
This is Rietveld 408576698