Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 2864023003: Fix the current per-frame URLLoaderFactory code path. (Closed)

Created:
3 years, 7 months ago by jam
Modified:
3 years, 7 months ago
Reviewers:
scottmg
CC:
chromium-reviews, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org, mlamouri+watch-content_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix the current per-frame URLLoaderFactory code path. BUG=712913, 718757 Review-Url: https://codereview.chromium.org/2864023003 Cr-Commit-Position: refs/heads/master@{#469786} Committed: https://chromium.googlesource.com/chromium/src/+/9380ddb9f45e2f441d4e6c4daffba47ac4e40e46

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -31 lines) Patch
M content/child/request_extra_data.h View 3 chunks +9 lines, -0 lines 0 comments Download
M content/child/request_extra_data.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/child/web_url_loader_impl.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/render_frame_impl.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/renderer_blink_platform_impl.cc View 2 chunks +13 lines, -26 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
jam
3 years, 7 months ago (2017-05-05 18:19:58 UTC) #4
scottmg
So this is getting the network one in renderer_blink_platform_impl.cc first and then replacing it on ...
3 years, 7 months ago (2017-05-05 18:43:44 UTC) #6
jam
On 2017/05/05 18:43:44, scottmg wrote: > So this is getting the network one in renderer_blink_platform_impl.cc ...
3 years, 7 months ago (2017-05-05 19:33:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2864023003/1
3 years, 7 months ago (2017-05-05 19:33:46 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-05 22:51:34 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9380ddb9f45e2f441d4e6c4daffb...

Powered by Google App Engine
This is Rietveld 408576698