Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2863993002:
cros: Defer primary user meta update until active (Closed)
Descriptioncros: Defer primary user meta update until active
Defer the meta/order update to ash until session state becomes
active for primary user. So that ash side code could be simplified
to expect having a consistent state for both primary user session
and secondary user sessions.
BUG=718458
Review-Url: https://codereview.chromium.org/2863993002
Cr-Commit-Position: refs/heads/master@{#470048}
Committed: https://chromium.googlesource.com/chromium/src/+/4cfa57df48555a9f2f54d2f5cb78a3db29b3b187
Patch Set 1 #Patch Set 2 : fix compile #Patch Set 3 : fix tests #Patch Set 4 : rebase #
Total comments: 6
Patch Set 5 : fix nits #
Messages
Total messages: 27 (20 generated)
The CQ bit was checked by xiyuan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
The CQ bit was checked by xiyuan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by xiyuan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
xiyuan@chromium.org changed reviewers: + afakhry@chromium.org, jamescook@chromium.org
LGTM https://codereview.chromium.org/2863993002/diff/60001/chrome/browser/ui/ash/s... File chrome/browser/ui/ash/session_controller_client.cc (right): https://codereview.chromium.org/2863993002/diff/60001/chrome/browser/ui/ash/s... chrome/browser/ui/ash/session_controller_client.cc:192: // UserAddedToSession is not called for the primary user session so its meta It would be very nice if it was called. Hopefully that is part of the work for crbug.com/657149 The state changes in this class are very confusing right now. https://codereview.chromium.org/2863993002/diff/60001/chrome/browser/ui/ash/s... chrome/browser/ui/ash/session_controller_client.cc:198: // meta sent until it becomes active so that ash side could expect a super nit: "meta" -> "metadata"? https://codereview.chromium.org/2863993002/diff/60001/chrome/browser/ui/ash/s... chrome/browser/ui/ash/session_controller_client.cc:325: // Sent the primary user meta and order that are deferred from super nit: "meta" -> "metadata"?
The CQ bit was checked by xiyuan@chromium.org to run a CQ dry run
https://codereview.chromium.org/2863993002/diff/60001/chrome/browser/ui/ash/s... File chrome/browser/ui/ash/session_controller_client.cc (right): https://codereview.chromium.org/2863993002/diff/60001/chrome/browser/ui/ash/s... chrome/browser/ui/ash/session_controller_client.cc:192: // UserAddedToSession is not called for the primary user session so its meta On 2017/05/08 16:23:02, James Cook (sheriff - slow) wrote: > It would be very nice if it was called. Hopefully that is part of the work for > crbug.com/657149 > > The state changes in this class are very confusing right now. Agree. I don't know why we send out ActiveUserChanged so early for the primary user but not for secondary users. Probably because this was a simple replacement for UserLoggedIn when we introduce multiprofile feature. This makes the dependent code confusing and difficult to get right. The refactor should address this. https://codereview.chromium.org/2863993002/diff/60001/chrome/browser/ui/ash/s... chrome/browser/ui/ash/session_controller_client.cc:198: // meta sent until it becomes active so that ash side could expect a On 2017/05/08 16:23:02, James Cook (sheriff - slow) wrote: > super nit: "meta" -> "metadata"? Done. https://codereview.chromium.org/2863993002/diff/60001/chrome/browser/ui/ash/s... chrome/browser/ui/ash/session_controller_client.cc:325: // Sent the primary user meta and order that are deferred from On 2017/05/08 16:23:02, James Cook (sheriff - slow) wrote: > super nit: "meta" -> "metadata"? Done.
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
still lgtm, thanks for the info on refactor
The CQ bit was checked by xiyuan@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2017/05/08 17:09:47, James Cook (sheriff - slow) wrote: > still lgtm, thanks for the info on refactor LGTM. I tried this patch and it works for the primary user login as well as user switches. Thanks! Now I don't have to listen to OnSessionStateChanged().
CQ is committing da patch.
Bot data: {"patchset_id": 80001, "attempt_start_ts": 1494265802676650,
"parent_rev": "752948ba8f63184d42f7188a82d5580686e428f6", "commit_rev":
"4cfa57df48555a9f2f54d2f5cb78a3db29b3b187"}
Message was sent while issue was closed.
Description was changed from ========== cros: Defer primary user meta update until active Defer the meta/order update to ash until session state becomes active for primary user. So that ash side code could be simplified to expect having a consistent state for both primary user session and secondary user sessions. BUG=718458 ========== to ========== cros: Defer primary user meta update until active Defer the meta/order update to ash until session state becomes active for primary user. So that ash side code could be simplified to expect having a consistent state for both primary user session and secondary user sessions. BUG=718458 Review-Url: https://codereview.chromium.org/2863993002 Cr-Commit-Position: refs/heads/master@{#470048} Committed: https://chromium.googlesource.com/chromium/src/+/4cfa57df48555a9f2f54d2f5cb78... ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as https://chromium.googlesource.com/chromium/src/+/4cfa57df48555a9f2f54d2f5cb78... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
