[MD settings] .settings-row.wide and reduce use of flex layout

[MD settings] .settings-row.wide and reduce use of flex layout

This CL adds a .wide option to settings-row to expand content settings
url display. This further reduces use of flex layout in Appearance and
Search.

BUG=718702
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2863973004
Cr-Commit-Position: refs/heads/master@{#470139}
Committed: https://chromium.googlesource.com/chromium/src/+/15b04452364e8098753722f0faa7a57690428660

[dschuyler, 2017-05-05 23:28:50]

Description was changed from

==========
[MD settings] .settings-row.wide and reduce use of flex layout

This CL adds a .wide option to settings-row to expand content settings
url display. This further reduces use of flex layout in Appearance and
Search.

BUG=718702
==========

to

==========
[MD settings] .settings-row.wide and reduce use of flex layout

This CL adds a .wide option to settings-row to expand content settings
url display. This further reduces use of flex layout in Appearance and
Search.

BUG=718702
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dschuyler, 2017-05-05 23:28:52]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-05 23:29:55]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2017-05-05 23:31:30]

dschuyler@chromium.org changed reviewers:
+ hcarmona@chromium.org

[commit-bot: I haz the power, 2017-05-05 23:55:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-05 23:55:09]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[hcarmona, 2017-05-06 01:26:32]

https://codereview.chromium.org/2863973004/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/settings_shared_css.html (right):

https://codereview.chromium.org/2863973004/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/settings_shared_css.html:325: *
https://www.google.com/search?q=flexbox+truncated+text&oq=flexbox+truncated+text
*/
Can we point to a more concrete source rather than a google search?

[dschuyler, 2017-05-06 01:32:43]

https://codereview.chromium.org/2863973004/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/settings_shared_css.html (right):

https://codereview.chromium.org/2863973004/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/settings_shared_css.html:325: *
https://www.google.com/search?q=flexbox+truncated+text&oq=flexbox+truncated+text
*/
On 2017/05/06 01:26:32, hcarmona wrote:
> Can we point to a more concrete source rather than a google search?

I'd prefer to remove the reference.
I didn't want to include a link to any particular third party reference to the
subject. wdyt?

[hcarmona, 2017-05-06 01:33:39]

On 2017/05/06 01:32:43, dschuyler wrote:
>
https://codereview.chromium.org/2863973004/diff/1/chrome/browser/resources/se...
> File chrome/browser/resources/settings/settings_shared_css.html (right):
> 
>
https://codereview.chromium.org/2863973004/diff/1/chrome/browser/resources/se...
> chrome/browser/resources/settings/settings_shared_css.html:325: *
>
https://www.google.com/search?q=flexbox+truncated+text&oq=flexbox+truncated+text
> */
> On 2017/05/06 01:26:32, hcarmona wrote:
> > Can we point to a more concrete source rather than a google search?
> 
> I'd prefer to remove the reference.
> I didn't want to include a link to any particular third party reference to the
> subject. wdyt?

Sounds good. LGTM

[dschuyler, 2017-05-06 01:38:33]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-06 01:39:26]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2017-05-06 01:39:40]

https://codereview.chromium.org/2863973004/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/settings_shared_css.html (right):

https://codereview.chromium.org/2863973004/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/settings_shared_css.html:325: *
https://www.google.com/search?q=flexbox+truncated+text&oq=flexbox+truncated+text
*/
On 2017/05/06 01:32:43, dschuyler wrote:
> On 2017/05/06 01:26:32, hcarmona wrote:
> > Can we point to a more concrete source rather than a google search?
> 
> I'd prefer to remove the reference.
> I didn't want to include a link to any particular third party reference to the
> subject. wdyt?

Done.

[commit-bot: I haz the power, 2017-05-06 02:44:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-06 02:44:07]

Dry run: This issue passed the CQ dry run.

[dschuyler, 2017-05-08 19:04:57]

The CQ bit was checked by dschuyler@chromium.org

[dschuyler, 2017-05-08 19:04:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
hcarmona@chromium.org
Link to the patchset: https://codereview.chromium.org/2863973004/#ps20001
(title: "comment change")

[commit-bot: I haz the power, 2017-05-08 19:05:46]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 19:13:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 19:13:19]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[dschuyler, 2017-05-08 20:49:14]

The CQ bit was checked by dschuyler@chromium.org

[commit-bot: I haz the power, 2017-05-08 20:50:07]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 21:43:40]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494276554763930,
"parent_rev": "eee2186f0e38677b7fa0e804da2037b07ab7b6c5", "commit_rev":
"15b04452364e8098753722f0faa7a57690428660"}

[commit-bot: I haz the power, 2017-05-08 21:43:55]

Description was changed from

==========
[MD settings] .settings-row.wide and reduce use of flex layout

This CL adds a .wide option to settings-row to expand content settings
url display. This further reduces use of flex layout in Appearance and
Search.

BUG=718702
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD settings] .settings-row.wide and reduce use of flex layout

This CL adds a .wide option to settings-row to expand content settings
url display. This further reduces use of flex layout in Appearance and
Search.

BUG=718702
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2863973004
Cr-Commit-Position: refs/heads/master@{#470139}
Committed:
https://chromium.googlesource.com/chromium/src/+/15b04452364e8098753722f0faa7...
==========

[commit-bot: I haz the power, 2017-05-08 21:43:56]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/15b04452364e8098753722f0faa7...