Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Unified Diff: content/common/renderer.mojom

Issue 2863973003: Expose RTT and downlink bandwidth using experimental Javascript API (Closed)
Patch Set: Rebase, haraken's comment Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/renderer.mojom
diff --git a/content/common/renderer.mojom b/content/common/renderer.mojom
index b860044d7414fda2a3b01cd37ca535aeddc844b7..dbdd196714cf3a07e6a23cabca36d3c2be2650f5 100644
--- a/content/common/renderer.mojom
+++ b/content/common/renderer.mojom
@@ -6,6 +6,7 @@ module content.mojom;
import "content/common/native_types.mojom";
import "ipc/ipc.mojom";
+import "mojo/common/time.mojom";
import "ui/gfx/geometry/mojo/geometry.mojom";
import "ui/gfx/mojo/icc_profile.mojom";
@@ -158,12 +159,13 @@ interface Renderer {
double max_bandwidth_mbps);
// Tells the renderer process that the network quality estimate has changed.
- // The RTT estimates are in milliseconds, while the downstream throughput is
- // computed in kilobits per second. If an estimate of the HTTP or transport
- // RTT is unavailable, it will be set to net::nqe::internal::InvalidRTT(). If
- // the throughput estimate is unavailable, it will be set to
- // net::nqe::internal::kInvalidThroughput.
- OnNetworkQualityChanged(double http_rtt_msec, double transport_rtt_msec, double bandwidth_kbps);
+ // The downstream throughput is computed in kilobits per second. If an
+ // estimate of the HTTP or transport RTT is unavailable, it will be set to
+ // net::nqe::internal::InvalidRTT(). If the throughput estimate is
+ // unavailable, it will be set to net::nqe::internal::kInvalidThroughput.
+ OnNetworkQualityChanged(mojo.common.mojom.TimeDelta http_rtt,
+ mojo.common.mojom.TimeDelta transport_rtt,
nasko 2017/05/19 19:36:29 No need for an empty line here.
tbansal1 2017/05/19 20:16:27 Assuming I understand the comment correctly -- The
+ double bandwidth_kbps);
// Tells the renderer to suspend/resume the webkit timers. Only for use on
// Android.

Powered by Google App Engine
This is Rietveld 408576698