Expose RTT and downlink bandwidth using experimental Javascript API

content/common/renderer.mojom

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 module content.mojom;
 
 import "content/common/native_types.mojom";
 import "ipc/ipc.mojom";
+import "mojo/common/time.mojom";
 import "ui/gfx/geometry/mojo/geometry.mojom";
 import "ui/gfx/mojo/icc_profile.mojom";
 
 struct CreateViewParams {
   // Renderer-wide preferences.
   RendererPreferences renderer_preferences;
 
   // Preferences for this view.
   WebPreferences web_preferences;
 
@@ skipping 132 matching lines @@
   CreateFrameProxy(int32 routing_id, int32 render_view_routing_id,
                    int32 opener_routing_id, int32 parent_routing_id,
                    FrameReplicationState replication_state);
 
   // Tells the renderer that the network type has changed so that
   // navigator.onLine and navigator.connection can be updated.
   OnNetworkConnectionChanged(NetworkConnectionType connection_type,
                              double max_bandwidth_mbps);
 
   // Tells the renderer process that the network quality estimate has changed.
-  // The RTT estimates are in milliseconds, while the downstream throughput is
-  // computed in kilobits per second. If an estimate of the HTTP or transport
-  // RTT is unavailable, it will be set to net::nqe::internal::InvalidRTT(). If
-  // the throughput estimate is unavailable, it will be set to
-  // net::nqe::internal::kInvalidThroughput.
-  OnNetworkQualityChanged(double http_rtt_msec, double transport_rtt_msec, double bandwidth_kbps);
+  // The downstream throughput is computed in kilobits per second. If an
+  // estimate of the HTTP or transport RTT is unavailable, it will be set to 
+  // net::nqe::internal::InvalidRTT(). If the throughput estimate is
+  // unavailable, it will be set to net::nqe::internal::kInvalidThroughput.
+  OnNetworkQualityChanged(mojo.common.mojom.TimeDelta http_rtt,
+                          mojo.common.mojom.TimeDelta transport_rtt,

[nasko, 2017/05/19 19:36:29]

No need for an empty line here.

[tbansal1, 2017/05/19 20:16:27]

Assuming I understand the comment correctly -- There is no empty line here. It
looks like there is one due to the way the diffs are shown.

+                          double bandwidth_kbps);
 
   // Tells the renderer to suspend/resume the webkit timers. Only for use on
   // Android.
   SetWebKitSharedTimersSuspended(bool suspend);
 
   // Tells the renderer about a scrollbar appearance change. Only for use on
   // OS X.
   UpdateScrollbarTheme(UpdateScrollbarThemeParams params);
 
   // Notification that the OS X Aqua color preferences changed.
   OnSystemColorsChanged(int32 aqua_color_variant, string highlight_text_color,
                         string highlight_color);
 
   // Tells the renderer to empty its plugin list cache, optional reloading
   // pages containing plugins.
   PurgePluginListCache(bool reload_pages);
 };