Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Issue 2863953003: Headless: Remove obsolete Mojo code and some other obsolete APIs (Closed)

Created:
3 years, 7 months ago by alex clarke (OOO till 29th)
Modified:
3 years, 7 months ago
Reviewers:
Mike West, Sami
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), devtools-reviews_chromium.org, pfeldman, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Headless: Remove obsolete Mojo code and some other obsolete APIs BUG=546953 Review-Url: https://codereview.chromium.org/2863953003 Cr-Commit-Position: refs/heads/master@{#470280} Committed: https://chromium.googlesource.com/chromium/src/+/1b6728287ccd6d494774ac4f351dac9daa92d8a5

Patch Set 1 #

Total comments: 2

Patch Set 2 : Assume headless_browser_context_ is not null #

Patch Set 3 : Remove the mojom too #

Patch Set 4 : Fix GenericURLRequestJobTest #

Patch Set 5 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -433 lines) Patch
M headless/BUILD.gn View 1 2 3 4 3 chunks +0 lines, -35 lines 0 comments Download
M headless/app/headless_shell.cc View 1 2 3 4 2 chunks +11 lines, -0 lines 0 comments Download
M headless/lib/browser/headless_browser_context_impl.cc View 1 2 3 4 1 chunk +0 lines, -8 lines 0 comments Download
M headless/lib/browser/headless_web_contents_impl.h View 1 2 3 4 2 chunks +0 lines, -7 lines 0 comments Download
M headless/lib/browser/headless_web_contents_impl.cc View 5 chunks +18 lines, -37 lines 0 comments Download
D headless/lib/embedder_mojo_browsertest.cc View 1 chunk +0 lines, -262 lines 0 comments Download
D headless/lib/embedder_test.mojom View 1 2 1 chunk +0 lines, -11 lines 0 comments Download
D headless/lib/headless_browsertest_resources.grd View 1 chunk +0 lines, -16 lines 0 comments Download
M headless/lib/headless_devtools_client_browsertest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M headless/public/headless_browser_context.h View 1 chunk +0 lines, -9 lines 0 comments Download
M headless/public/headless_web_contents.h View 1 2 3 4 2 chunks +0 lines, -24 lines 0 comments Download
M headless/public/util/deterministic_http_protocol_handler.h View 2 chunks +7 lines, -0 lines 0 comments Download
M headless/public/util/deterministic_http_protocol_handler.cc View 2 chunks +2 lines, -1 line 0 comments Download
M headless/public/util/generic_url_request_job.h View 1 chunk +6 lines, -8 lines 0 comments Download
M headless/public/util/generic_url_request_job.cc View 1 2 3 4 1 chunk +3 lines, -10 lines 0 comments Download
M headless/public/util/generic_url_request_job_test.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 32 (22 generated)
alex clarke (OOO till 29th)
PTAL
3 years, 7 months ago (2017-05-05 14:45:50 UTC) #2
Sami
lgtm, thanks for the cleanup! https://codereview.chromium.org/2863953003/diff/1/headless/public/util/generic_url_request_job.cc File headless/public/util/generic_url_request_job.cc (right): https://codereview.chromium.org/2863953003/diff/1/headless/public/util/generic_url_request_job.cc#newcode205 headless/public/util/generic_url_request_job.cc:205: if (headless_browser_context_ && Is ...
3 years, 7 months ago (2017-05-05 16:57:13 UTC) #3
alex clarke (OOO till 29th)
https://codereview.chromium.org/2863953003/diff/1/headless/public/util/generic_url_request_job.cc File headless/public/util/generic_url_request_job.cc (right): https://codereview.chromium.org/2863953003/diff/1/headless/public/util/generic_url_request_job.cc#newcode205 headless/public/util/generic_url_request_job.cc:205: if (headless_browser_context_ && On 2017/05/05 16:57:13, Sami wrote: > ...
3 years, 7 months ago (2017-05-08 10:08:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2863953003/20001
3 years, 7 months ago (2017-05-08 10:21:07 UTC) #10
alex clarke (OOO till 29th)
+mkwst@ I need your stamp to remove the mojom files.
3 years, 7 months ago (2017-05-08 10:24:20 UTC) #14
Mike West
Removing .mojo LGTM!
3 years, 7 months ago (2017-05-08 10:52:27 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2863953003/60001
3 years, 7 months ago (2017-05-09 07:28:25 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/430902)
3 years, 7 months ago (2017-05-09 07:35:24 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2863953003/80001
3 years, 7 months ago (2017-05-09 07:43:22 UTC) #29
commit-bot: I haz the power
3 years, 7 months ago (2017-05-09 11:27:17 UTC) #32
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/1b6728287ccd6d494774ac4f351d...

Powered by Google App Engine
This is Rietveld 408576698