Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 2863953002: Revert of [heap] Reland "Make non-atomic markbit operations consistent with atomic ones." (Closed)

Created:
3 years, 7 months ago by ulan
Modified:
3 years, 7 months ago
Reviewers:
Michael Lippautz
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office)
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [heap] Reland "Make non-atomic markbit operations consistent with atomic ones." (patchset #2 id:20001 of https://codereview.chromium.org/2860323003/ ) Reason for revert: box2d failures on buildbot Original issue's description: > [heap] Reland "Make non-atomic markbit operations consistent with atomic ones." > > Now non-atomic color transition operations return a boolean indicating > whether the transition succeeded or not. > > This allows to replace color check and transition operations with a > single transition operation. For example: > > if (IsWhite(object)) { > WhiteToBlack(object); > Foo(); > } > > becomes > > if (WhiteToBlack(object)) { > Foo(); > } > > BUG=chromium:694255 > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_rel_ng > > Review-Url: https://codereview.chromium.org/2860323003 > Cr-Commit-Position: refs/heads/master@{#45123} > Committed: https://chromium.googlesource.com/v8/v8/+/c0a65cd295301f334e2bbfcce46a937cd708beec TBR=mlippautz@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:694255 Review-Url: https://codereview.chromium.org/2863953002 Cr-Commit-Position: refs/heads/master@{#45127} Committed: https://chromium.googlesource.com/v8/v8/+/b7b3781b8747d597cf0910c65221ad2b1881e0e4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -114 lines) Patch
M src/heap/heap.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/heap/incremental-marking.h View 3 chunks +6 lines, -11 lines 0 comments Download
M src/heap/incremental-marking.cc View 11 chunks +41 lines, -42 lines 0 comments Download
M src/heap/mark-compact.h View 2 chunks +9 lines, -2 lines 0 comments Download
M src/heap/mark-compact.cc View 9 chunks +59 lines, -40 lines 0 comments Download
M src/heap/mark-compact-inl.h View 1 chunk +6 lines, -2 lines 0 comments Download
M src/heap/marking.h View 4 chunks +15 lines, -14 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
ulan
Created Revert of [heap] Reland "Make non-atomic markbit operations consistent with atomic ones."
3 years, 7 months ago (2017-05-05 11:17:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2863953002/1
3 years, 7 months ago (2017-05-05 11:17:10 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-05 11:17:21 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/b7b3781b8747d597cf0910c65221ad2b188...

Powered by Google App Engine
This is Rietveld 408576698