chromeos: makes mus send keyevents to display root when nothing has focus

chromeos: makes mus send keyevents to display root when nothing has focus

Prior to this change if no windows have focus then the KeyEvent is
dropped. This change makes it so that if no windows have focus then
the KeyEvent is targetted to the window manager. This makes it so
accelerators work in mushrome (accelerators in mushrome are
implemented using classic-ash mechanism, *not* as accelerators
registered with mus).

BUG=717676
TEST=covered by tests
R=sadrul@chromium.org

Review-Url: https://codereview.chromium.org/2863913004
Cr-Commit-Position: refs/heads/master@{#470032}
Committed: https://chromium.googlesource.com/chromium/src/+/9af279fc5d9475d998c2080bb62be6a732279827

[sky, 2017-05-05 22:20:04]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-05 22:21:05]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sky, 2017-05-05 22:22:14]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-05 22:23:00]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-05 23:22:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-05 23:22:22]

Dry run: This issue passed the CQ dry run.

[sadrul, 2017-05-08 15:24:19]

lgtm

https://codereview.chromium.org/2863913004/diff/40001/services/ui/ws/window_m...
File services/ui/ws/window_manager_state.cc (right):

https://codereview.chromium.org/2863913004/diff/40001/services/ui/ws/window_m...
services/ui/ws/window_manager_state.cc:393: return
display_root->root()->children()[0];
Maybe there should be a WindowManagerDisplayRoot::Get[Client]VisibleRoot() or
something like that? Because most code will probably end up using
WindowManagerDisplayRoot::root(), unaware that there may be a different root to
consider.

[sky, 2017-05-08 15:53:00]

https://codereview.chromium.org/2863913004/diff/40001/services/ui/ws/window_m...
File services/ui/ws/window_manager_state.cc (right):

https://codereview.chromium.org/2863913004/diff/40001/services/ui/ws/window_m...
services/ui/ws/window_manager_state.cc:393: return
display_root->root()->children()[0];
On 2017/05/08 15:24:19, sadrul wrote:
> Maybe there should be a WindowManagerDisplayRoot::Get[Client]VisibleRoot() or
> something like that? Because most code will probably end up using
> WindowManagerDisplayRoot::root(), unaware that there may be a different root
to
> consider.

Good idea. Done.

[sky, 2017-05-08 15:53:04]

The CQ bit was checked by sky@chromium.org

[sky, 2017-05-08 15:53:05]

The patchset sent to the CQ was uploaded after l-g-t-m from sadrul@chromium.org
Link to the patchset: https://codereview.chromium.org/2863913004/#ps60001
(title: "GetClientVisibleRoot")

[commit-bot: I haz the power, 2017-05-08 15:53:37]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 16:12:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 16:12:17]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[sky, 2017-05-08 16:53:41]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2017-05-08 16:54:17]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 17:10:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 17:10:37]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[sky, 2017-05-08 17:13:38]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2017-05-08 17:13:55]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 17:23:52]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1494263618081410,
"parent_rev": "c3f601b77244b4aecf31bcab65c7e80e9a847ad0", "commit_rev":
"9af279fc5d9475d998c2080bb62be6a732279827"}

[commit-bot: I haz the power, 2017-05-08 17:24:03]

Description was changed from

==========
chromeos: makes mus send keyevents to display root when nothing has focus

Prior to this change if no windows have focus then the KeyEvent is
dropped. This change makes it so that if no windows have focus then
the KeyEvent is targetted to the window manager. This makes it so
accelerators work in mushrome (accelerators in mushrome are
implemented using classic-ash mechanism, *not* as accelerators
registered with mus).

BUG=717676
TEST=covered by tests
R=sadrul@chromium.org
==========

to

==========
chromeos: makes mus send keyevents to display root when nothing has focus

Prior to this change if no windows have focus then the KeyEvent is
dropped. This change makes it so that if no windows have focus then
the KeyEvent is targetted to the window manager. This makes it so
accelerators work in mushrome (accelerators in mushrome are
implemented using classic-ash mechanism, *not* as accelerators
registered with mus).

BUG=717676
TEST=covered by tests
R=sadrul@chromium.org

Review-Url: https://codereview.chromium.org/2863913004
Cr-Commit-Position: refs/heads/master@{#470032}
Committed:
https://chromium.googlesource.com/chromium/src/+/9af279fc5d9475d998c2080bb62b...
==========

[commit-bot: I haz the power, 2017-05-08 17:24:05]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/9af279fc5d9475d998c2080bb62b...