[Presentation API] Change controller connection to 'terminated' when receiver connection terminates

[Presentation API] Change controller connection to 'terminated' when receiver connection terminates

When calling receiver connection.terminate(), we rely on MRP to change controller connection to 'terminated'. If receiver page goes away before MRP finishes setting up mirroring, MPR will signal 'closed' instead of 'terminated'. Fix this by making receiver connection proxy signal 'terminated' to controller connection when receiver frame goes away at browser side.

BUG=712858
Review-Url: https://codereview.chromium.org/2863903002
Cr-Commit-Position: refs/heads/master@{#472860}
Committed: https://chromium.googlesource.com/chromium/src/+/265357c7a152a62f98e998111f8b77c3779a234a

[zhaobin, 2017-05-05 17:43:26]

zhaobin@chromium.org changed reviewers:
+ imcheng@chromium.org, mfoltz@chromium.org

[mark a. foltz, 2017-05-09 22:47:54]

On 2017/05/05 at 17:43:27, zhaobin wrote:
> 

I need a little time to sort through this patch, since this state change logic
is spread between Blink and content/renderer.

I didn't like seeing a duplicate list of receiver connections maintained in
content/renderer when there is already one in PresentationConnectionList.

Would the following design be possible?

1. Have PresentationReceiver to get a call from WebPresentationReceiver that the
presentation has been terminated
2. Have it set the terminated state on all members of PresentationConnectionList
without firing events
3. Call didChangeState() to update embedder connection objects (proxies)

[zhaobin, 2017-05-10 22:05:58]

- Removed receiver_connection_proxy list from PresentationDispatcher
- Added NotifyTargetConnection() function to PresentationConnection and
PresentationConnectionProxy.
- Call didChangeState() to update embedder connection objects (proxies) when
presentation receiver terminates connections

[mark a. foltz, 2017-05-12 22:10:19]

LGTM, this looks much simpler and in line with the existing proxy design. 
Thanks :-)

Can a layout test be written for this change?

[zhaobin, 2017-05-15 23:19:02]

The CQ bit was checked by zhaobin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-15 23:20:17]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 00:16:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 00:16:43]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[zhaobin, 2017-05-16 17:55:29]

The CQ bit was checked by zhaobin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-16 17:56:46]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 19:58:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 19:58:26]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[zhaobin, 2017-05-16 20:03:14]

The CQ bit was checked by zhaobin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-16 20:05:25]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 22:17:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 22:17:06]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[zhaobin, 2017-05-16 22:28:49]

The CQ bit was checked by zhaobin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-16 22:30:46]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 23:17:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 23:17:29]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[zhaobin, 2017-05-17 17:38:47]

The CQ bit was checked by zhaobin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 17:40:23]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 19:43:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 19:43:43]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[zhaobin, 2017-05-17 20:27:04]

The CQ bit was checked by zhaobin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 20:28:26]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[zhaobin, 2017-05-17 22:37:06]

The CQ bit was checked by zhaobin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 22:38:06]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 04:48:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 04:48:50]

Dry run: This issue passed the CQ dry run.

[zhaobin, 2017-05-18 17:29:51]

The CQ bit was checked by zhaobin@chromium.org

[zhaobin, 2017-05-18 17:29:52]

The patchset sent to the CQ was uploaded after l-g-t-m from mfoltz@chromium.org
Link to the patchset: https://codereview.chromium.org/2863903002/#ps60001
(title: "fix layout test failures")

[commit-bot: I haz the power, 2017-05-18 17:31:11]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 17:40:16]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1495128591819490,
"parent_rev": "15cfdc4408fe45fea2657592c9bd3dbf6ade27af", "commit_rev":
"265357c7a152a62f98e998111f8b77c3779a234a"}

[commit-bot: I haz the power, 2017-05-18 17:40:27]

Description was changed from

==========
[Presentation API] Change controller connection to 'terminated' when receiver
connection terminates

When calling receiver connection.terminate(), we rely on MRP to change
controller connection to 'terminated'. If receiver page goes away before MRP
finishes setting up mirroring, MPR will signal 'closed' instead of 'terminated'.
Fix this by making receiver connection proxy signal 'terminated' to controller
connection when receiver frame goes away at browser side.

BUG=712858
==========

to

==========
[Presentation API] Change controller connection to 'terminated' when receiver
connection terminates

When calling receiver connection.terminate(), we rely on MRP to change
controller connection to 'terminated'. If receiver page goes away before MRP
finishes setting up mirroring, MPR will signal 'closed' instead of 'terminated'.
Fix this by making receiver connection proxy signal 'terminated' to controller
connection when receiver frame goes away at browser side.

BUG=712858

Review-Url: https://codereview.chromium.org/2863903002
Cr-Commit-Position: refs/heads/master@{#472860}
Committed:
https://chromium.googlesource.com/chromium/src/+/265357c7a152a62f98e998111f8b...
==========

[commit-bot: I haz the power, 2017-05-18 17:40:28]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/265357c7a152a62f98e998111f8b...