Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2863893002: [TTS] Remove two unused metrics. (Closed)

Created:
3 years, 7 months ago by Donn Denman
Modified:
3 years, 7 months ago
Reviewers:
Theresa, Steven Holte
CC:
chromium-reviews, twellington+watch_chromium.org, mdjones+watch_chromium.org, donnd+watch_chromium.org, asvitkine+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[TTS] Remove two unused metrics. Removes metric collection for whether the selection is all-caps and whether the selection was within a URL (using a regexp). Removes the logging and metrics and deprecates the histograms for two metrics that are no longer needed: - Search.ContextualSearchAllCapsResultsSeen - Search.ContextualSearchResultsSeenSelectionWasUrl BUG= Review-Url: https://codereview.chromium.org/2863893002 Cr-Commit-Position: refs/heads/master@{#470060} Committed: https://chromium.googlesource.com/chromium/src/+/dae4e67ec7c4e1d3b1562ec4327bd7a85127daa2

Patch Set 1 #

Messages

Total messages: 16 (9 generated)
Donn Denman
Theresa, PTAL.
3 years, 7 months ago (2017-05-05 17:00:28 UTC) #6
Donn Denman
On 2017/05/05 17:00:28, Donn Denman wrote: > Theresa, PTAL. Friendly Ping!
3 years, 7 months ago (2017-05-05 22:01:57 UTC) #7
Theresa
lgtm
3 years, 7 months ago (2017-05-05 22:14:05 UTC) #8
Donn Denman
Steven, PTAL at histograms.xml -- just deprecating two histograms that are no longer needed.
3 years, 7 months ago (2017-05-05 22:15:38 UTC) #10
Steven Holte
lgtm
3 years, 7 months ago (2017-05-05 23:02:27 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2863893002/1
3 years, 7 months ago (2017-05-08 17:03:38 UTC) #13
commit-bot: I haz the power
3 years, 7 months ago (2017-05-08 18:42:45 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/dae4e67ec7c4e1d3b1562ec4327b...

Powered by Google App Engine
This is Rietveld 408576698