Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Unified Diff: third_party/WebKit/Source/core/frame/WebLocalFrameBase.h

Issue 2863853002: Introduce the class webLocalFrameBase anf make WebLocalFrameImpl derived it. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/web/WebLocalFrameImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/frame/WebLocalFrameBase.h
diff --git a/third_party/WebKit/Source/core/frame/WebLocalFrameBase.h b/third_party/WebKit/Source/core/frame/WebLocalFrameBase.h
new file mode 100644
index 0000000000000000000000000000000000000000..939c676958d21b42ac2a610174518c22b15a1f31
--- /dev/null
+++ b/third_party/WebKit/Source/core/frame/WebLocalFrameBase.h
@@ -0,0 +1,26 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.#ifndef WebViewBase_h
+
+#ifndef WebLocalFrameBase_h
+#define WebLocalFrameBase_h
+
+#include "public/web/WebLocalFrame.h"
+
+namespace blink {
+
+// WebLocalFrameBase is a temporary class the provides a layer of abstraction
+// for WebLocalFrameImpl. Mehtods that are declared public in WebLocalFrameImpl
+// that are not overrides from WebLocalFrame will be declared pure virtual in
+// WebLocalFrameBase. Classes that then have a dependency on WebLocalFrameImpl
+// will then take a dependency on WebLocalFrameBase instead, so we can remove
+// cyclic dependencies in web/ and move classes from web/ into core/ or
+// modules.
+// TODO(slangley): Remove this class once WebLocalFrameImpl is in core/
sashab 2017/05/05 01:10:13 Full stop at end of comment ;)
slangley 2017/05/05 01:18:49 Done
+class WebLocalFrameBase : public WebLocalFrame {
+ protected:
+ explicit WebLocalFrameBase(WebTreeScopeType scope) : WebLocalFrame(scope) {}
+};
+}
+
+#endif // WebLocalFrameBase_h
« no previous file with comments | « no previous file | third_party/WebKit/Source/web/WebLocalFrameImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698