Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Side by Side Diff: third_party/WebKit/Source/core/frame/WebLocalFrameBase.h

Issue 2863853002: Introduce the class webLocalFrameBase anf make WebLocalFrameImpl derived it. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/web/WebLocalFrameImpl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.#ifndef WebViewBase_h
4
5 #ifndef WebLocalFrameBase_h
6 #define WebLocalFrameBase_h
7
8 #include "public/web/WebLocalFrame.h"
9
10 namespace blink {
11
12 // WebLocalFrameBase is a temporary class the provides a layer of abstraction
13 // for WebLocalFrameImpl. Mehtods that are declared public in WebLocalFrameImpl
14 // that are not overrides from WebLocalFrame will be declared pure virtual in
15 // WebLocalFrameBase. Classes that then have a dependency on WebLocalFrameImpl
16 // will then take a dependency on WebLocalFrameBase instead, so we can remove
17 // cyclic dependencies in web/ and move classes from web/ into core/ or
18 // modules.
19 // TODO(slangley): Remove this class once WebLocalFrameImpl is in core/
sashab 2017/05/05 01:10:13 Full stop at end of comment ;)
slangley 2017/05/05 01:18:49 Done
20 class WebLocalFrameBase : public WebLocalFrame {
21 protected:
22 explicit WebLocalFrameBase(WebTreeScopeType scope) : WebLocalFrame(scope) {}
23 };
24 }
25
26 #endif // WebLocalFrameBase_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/web/WebLocalFrameImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698