|
|
Created:
3 years, 7 months ago by brucedawson Modified:
3 years, 7 months ago CC:
chromium-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionImprove linker_verbose_tracking.py
linker_verbose_tracking.py is used to analyze the verbose output from
the VC++ linker to help understand binary-size regressions. However some
of its messages are clear only to the original author, and it completely
fails on the utf-16 files created when redirecting the linker output
from powershell.
This change updates the script to handle both utf-16 and utf-8 files,
and improves the messages printed in a couple of cases.
R=dvallet@chromium.org
BUG=714841
Review-Url: https://codereview.chromium.org/2863843003
Cr-Commit-Position: refs/heads/master@{#469783}
Committed: https://chromium.googlesource.com/chromium/src/+/3647b59ef9a6cf01783c7cf7b5ea83eab3296007
Patch Set 1 #
Messages
Total messages: 19 (11 generated)
The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run
Description was changed from ========== Improve linker_verbose_tracking.py linker_verbose_tracking.py is used to analyze the verbose output from the VC++ linker to help understand binary-size regressions. However some of its messages are clear only to the original author, and it completely fails on the utf-16 files created when redirecting the linker output from powershell. This change handles utf-16 and utf-8 files, and improves the messages printed in a couple of cases. R=dvallet@chromium.org BUG=714841 ========== to ========== Improve linker_verbose_tracking.py linker_verbose_tracking.py is used to analyze the verbose output from the VC++ linker to help understand binary-size regressions. However some of its messages are clear only to the original author, and it completely fails on the utf-16 files created when redirecting the linker output from powershell. This change updates the script to handle both utf-16 and utf-8 files, and improves the messages printed in a couple of cases. R=dvallet@chromium.org BUG=714841 ==========
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
This should make the script work better for you. PTAL.
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by brucedawson@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
brucedawson@chromium.org changed reviewers: + stanisc@chromium.org
Stan, can you take a look? In addition to the fixes/features it improves the Python coding slightly.
lgtm
The CQ bit was checked by brucedawson@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1494023426171010, "parent_rev": "44775cadb6becb6297c7774333f188c866574feb", "commit_rev": "3647b59ef9a6cf01783c7cf7b5ea83eab3296007"}
Message was sent while issue was closed.
Description was changed from ========== Improve linker_verbose_tracking.py linker_verbose_tracking.py is used to analyze the verbose output from the VC++ linker to help understand binary-size regressions. However some of its messages are clear only to the original author, and it completely fails on the utf-16 files created when redirecting the linker output from powershell. This change updates the script to handle both utf-16 and utf-8 files, and improves the messages printed in a couple of cases. R=dvallet@chromium.org BUG=714841 ========== to ========== Improve linker_verbose_tracking.py linker_verbose_tracking.py is used to analyze the verbose output from the VC++ linker to help understand binary-size regressions. However some of its messages are clear only to the original author, and it completely fails on the utf-16 files created when redirecting the linker output from powershell. This change updates the script to handle both utf-16 and utf-8 files, and improves the messages printed in a couple of cases. R=dvallet@chromium.org BUG=714841 Review-Url: https://codereview.chromium.org/2863843003 Cr-Commit-Position: refs/heads/master@{#469783} Committed: https://chromium.googlesource.com/chromium/src/+/3647b59ef9a6cf01783c7cf7b5ea... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/3647b59ef9a6cf01783c7cf7b5ea... |