Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Issue 2863843003: Improve linker_verbose_tracking.py (Closed)

Created:
3 years, 7 months ago by brucedawson
Modified:
3 years, 7 months ago
Reviewers:
stanisc, dvallet
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Improve linker_verbose_tracking.py linker_verbose_tracking.py is used to analyze the verbose output from the VC++ linker to help understand binary-size regressions. However some of its messages are clear only to the original author, and it completely fails on the utf-16 files created when redirecting the linker output from powershell. This change updates the script to handle both utf-16 and utf-8 files, and improves the messages printed in a couple of cases. R=dvallet@chromium.org BUG=714841 Review-Url: https://codereview.chromium.org/2863843003 Cr-Commit-Position: refs/heads/master@{#469783} Committed: https://chromium.googlesource.com/chromium/src/+/3647b59ef9a6cf01783c7cf7b5ea83eab3296007

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -39 lines) Patch
M tools/win/linker_verbose_tracking.py View 4 chunks +55 lines, -39 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
brucedawson
This should make the script work better for you. PTAL.
3 years, 7 months ago (2017-05-05 00:04:55 UTC) #4
dvallet
lgtm
3 years, 7 months ago (2017-05-05 00:08:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2863843003/1
3 years, 7 months ago (2017-05-05 00:19:10 UTC) #9
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 7 months ago (2017-05-05 00:19:11 UTC) #11
brucedawson
Stan, can you take a look? In addition to the fixes/features it improves the Python ...
3 years, 7 months ago (2017-05-05 00:57:42 UTC) #13
stanisc
lgtm
3 years, 7 months ago (2017-05-05 02:15:04 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2863843003/1
3 years, 7 months ago (2017-05-05 22:33:07 UTC) #16
commit-bot: I haz the power
3 years, 7 months ago (2017-05-05 22:41:23 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3647b59ef9a6cf01783c7cf7b5ea...

Powered by Google App Engine
This is Rietveld 408576698