Don't expose EXT_color_buffer_half_float to GL 2.x

Don't expose EXT_color_buffer_half_float to GL 2.x

The required texture formats (GL_R16F, etc) are not in the core until
3.0.

We could, in principle, query the particular extensions required for
these formats (GL_ARB_texture_rg, etc), but this query is simpler and
equally effective in practice.

BUG=699278
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2863773002
Cr-Commit-Position: refs/heads/master@{#469512}
Committed: https://chromium.googlesource.com/chromium/src/+/2c0a34fb259f6d8381a4c6ddce21bc8850c6a806

[ccameron, 2017-05-04 21:58:01]

Description was changed from

==========
Don't expose EXT_color_buffer_half_float to GL 2.x

The required texture formats (GL_R16F, etc) are not in the core until
3.0.

We could, in principle, query the particular extensions required for
these formats (GL_ARB_texture_rg, etc), but this query is simpler and
equally effective in practice.

BUG=699278
==========

to

==========
Don't expose EXT_color_buffer_half_float to GL 2.x

The required texture formats (GL_R16F, etc) are not in the core until
3.0.

We could, in principle, query the particular extensions required for
these formats (GL_ARB_texture_rg, etc), but this query is simpler and
equally effective in practice.

BUG=699278
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[ccameron, 2017-05-04 21:59:00]

ccameron@chromium.org changed reviewers:
+ zmo@chromium.org

[ccameron, 2017-05-04 21:59:00]

ptal -- on desktop, we need to be sure that we support the required formats
before sending them to TexImage and testing if the resulting texture creates a
complete framebuffer.

[ccameron, 2017-05-04 22:00:02]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-04 22:00:38]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Zhenyao Mo, 2017-05-04 22:03:50]

lgtm

[Zhenyao Mo, 2017-05-04 22:07:23]

https://codereview.chromium.org/2863773002/diff/1/gpu/command_buffer/service/...
File gpu/command_buffer/service/feature_info.cc (right):

https://codereview.chromium.org/2863773002/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/feature_info.cc:1513:
gl_version_info_->IsAtLeastGL(3, 0)) {
Sorry, just realized this.  gl_version_info_->IsAtLeastGL(3, 0) will return
false on ES.  I think it should be
(gl_version_info_->is_es || gl_version_info_->IsAtLeastGL(3, 0))

[ccameron, 2017-05-04 22:18:16]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[ccameron, 2017-05-04 22:18:27]

Good point -- updated

https://codereview.chromium.org/2863773002/diff/1/gpu/command_buffer/service/...
File gpu/command_buffer/service/feature_info.cc (right):

https://codereview.chromium.org/2863773002/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/feature_info.cc:1513:
gl_version_info_->IsAtLeastGL(3, 0)) {
On 2017/05/04 22:07:23, Zhenyao Mo wrote:
> Sorry, just realized this.  gl_version_info_->IsAtLeastGL(3, 0) will return
> false on ES.  I think it should be
> (gl_version_info_->is_es || gl_version_info_->IsAtLeastGL(3, 0))

I think there is an implicit gl_version_info_->is_es in this .. but yeah, let's
make it explicit.

[commit-bot: I haz the power, 2017-05-04 22:18:49]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Zhenyao Mo, 2017-05-04 22:19:48]

On 2017/05/04 22:18:27, ccameron wrote:
> Good point -- updated
> 
>
https://codereview.chromium.org/2863773002/diff/1/gpu/command_buffer/service/...
> File gpu/command_buffer/service/feature_info.cc (right):
> 
>
https://codereview.chromium.org/2863773002/diff/1/gpu/command_buffer/service/...
> gpu/command_buffer/service/feature_info.cc:1513:
> gl_version_info_->IsAtLeastGL(3, 0)) {
> On 2017/05/04 22:07:23, Zhenyao Mo wrote:
> > Sorry, just realized this.  gl_version_info_->IsAtLeastGL(3, 0) will return
> > false on ES.  I think it should be
> > (gl_version_info_->is_es || gl_version_info_->IsAtLeastGL(3, 0))
> 
> I think there is an implicit gl_version_info_->is_es in this .. but yeah,
let's
> make it explicit.

lgtm

[ccameron, 2017-05-04 22:19:58]

The CQ bit was unchecked by ccameron@chromium.org

[ccameron, 2017-05-04 22:20:12]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2017-05-04 22:20:53]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 23:20:22]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493936412098890,
"parent_rev": "92650052047f581f5c7a400e379b24d0f2f15495", "commit_rev":
"d84f77f0b79fa4953dfd7b3175e11d74418cdb1b"}

[commit-bot: I haz the power, 2017-05-04 23:21:16]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493936412098890,
"parent_rev": "c3dc77999472e767e41a5a7b3a3a1af28a5b3bef", "commit_rev":
"2c0a34fb259f6d8381a4c6ddce21bc8850c6a806"}

[commit-bot: I haz the power, 2017-05-04 23:22:15]

Description was changed from

==========
Don't expose EXT_color_buffer_half_float to GL 2.x

The required texture formats (GL_R16F, etc) are not in the core until
3.0.

We could, in principle, query the particular extensions required for
these formats (GL_ARB_texture_rg, etc), but this query is simpler and
equally effective in practice.

BUG=699278
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Don't expose EXT_color_buffer_half_float to GL 2.x

The required texture formats (GL_R16F, etc) are not in the core until
3.0.

We could, in principle, query the particular extensions required for
these formats (GL_ARB_texture_rg, etc), but this query is simpler and
equally effective in practice.

BUG=699278
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2863773002
Cr-Commit-Position: refs/heads/master@{#469512}
Committed:
https://chromium.googlesource.com/chromium/src/+/2c0a34fb259f6d8381a4c6ddce21...
==========

[commit-bot: I haz the power, 2017-05-04 23:22:21]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2c0a34fb259f6d8381a4c6ddce21...