Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 2863723002: WebView: create AwSafeBrowsingBlockingPage (Closed)

Created:
3 years, 7 months ago by Nate Fischer
Modified:
3 years, 7 months ago
Reviewers:
Jialiu Lin, Torne
CC:
android-webview-reviews_chromium.org, chromium-reviews, grt+watch_chromium.org, timvolodine, vakh+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

WebView: create AwSafeBrowsingBlockingPage No change in logic. This creates an initial implementation of a new WebView-specific blocking page. This has no change in logic, but paves the way for choosing between two different blocking pages (loud and quiet). Currently, all this does is specify SBErrorDisplayOptions without depending on the defaults set in BaseBlockingPage. This exposes CreateControllerClient() in BaseBlockingPage as protected so that AwSafeBrowsingBlockingPage can take advantage of it. BUG=718545 Review-Url: https://codereview.chromium.org/2863723002 Cr-Commit-Position: refs/heads/master@{#469488} Committed: https://chromium.googlesource.com/chromium/src/+/8dae3f2fa9a36c7e1aaf60b12af07ff7a4e673ad

Patch Set 1 #

Patch Set 2 : Fixing comment, fixing forward decl. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -2 lines) Patch
M android_webview/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M android_webview/browser/DEPS View 1 chunk +1 line, -1 line 0 comments Download
A android_webview/browser/aw_safe_browsing_blocking_page.h View 1 1 chunk +41 lines, -0 lines 0 comments Download
A android_webview/browser/aw_safe_browsing_blocking_page.cc View 1 1 chunk +73 lines, -0 lines 0 comments Download
M android_webview/browser/aw_safe_browsing_ui_manager.h View 1 chunk +2 lines, -0 lines 0 comments Download
M android_webview/browser/aw_safe_browsing_ui_manager.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M components/safe_browsing/base_blocking_page.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (10 generated)
Nate Fischer
PTAL jialiul@: - android_webview/browser/DEPS change (needed to include security_interstitials/core) - components/safe_browsing/ torne@: - android_webview/
3 years, 7 months ago (2017-05-04 19:35:47 UTC) #6
Jialiu Lin
LGTM for components/safe_browsing/* and DEPS change.
3 years, 7 months ago (2017-05-04 19:58:16 UTC) #7
Torne
lgtm
3 years, 7 months ago (2017-05-04 22:07:51 UTC) #10
Nate Fischer
On 2017/05/04 at 22:07:51, torne wrote: > lgtm Thanks!
3 years, 7 months ago (2017-05-04 22:09:04 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2863723002/20001
3 years, 7 months ago (2017-05-04 22:09:22 UTC) #13
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 22:14:25 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8dae3f2fa9a36c7e1aaf60b12af0...

Powered by Google App Engine
This is Rietveld 408576698