Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2863713002:
[Media, Controls] Cleanup resize observer before dereferencing. (Closed)
Description[Media, Controls] Cleanup resize observer before dereferencing.
BUG=716506
TEST=existing tests
Review-Url: https://codereview.chromium.org/2863713002
Cr-Commit-Position: refs/heads/master@{#470066}
Committed: https://chromium.googlesource.com/chromium/src/+/11539c86d2827abf795281446643991e6705790a
Patch Set 1 #
Messages
Total messages: 27 (14 generated)
The CQ bit was checked by avayvod@chromium.org to run a CQ dry run
avayvod@chromium.org changed reviewers: + steimel@chromium.org
PTaL when you have time :)
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Do we also need to worry about disconnecting when MediaControlsImpl is destroyed? Or is MediaControlsImpl only destroyed when the MediaElement is also destroyed?
On 2017/05/04 at 20:55:17, steimel wrote: > Do we also need to worry about disconnecting when MediaControlsImpl is destroyed? Or is MediaControlsImpl only destroyed when the MediaElement is also destroyed? Good question. We'd have to worry if HTMLMediaElement or its subclasses were ever clearing the media_controls_ reference. However it doesn't do that and since HTMLMediaElement has a strong reference to MediaControls, both will only be destroyed together (unless media_controls_ was never initialized).
lgtm
The CQ bit was checked by avayvod@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
lgtm
The CQ bit was checked by avayvod@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by avayvod@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by avayvod@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1494264753338970, "parent_rev":
"5ca0afa64606b3552886035dec808592c10100d2", "commit_rev":
"11539c86d2827abf795281446643991e6705790a"}
Message was sent while issue was closed.
Description was changed from ========== [Media, Controls] Cleanup resize observer before dereferencing. BUG=716506 TEST=existing tests ========== to ========== [Media, Controls] Cleanup resize observer before dereferencing. BUG=716506 TEST=existing tests Review-Url: https://codereview.chromium.org/2863713002 Cr-Commit-Position: refs/heads/master@{#470066} Committed: https://chromium.googlesource.com/chromium/src/+/11539c86d2827abf795281446643... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/11539c86d2827abf795281446643... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
