Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 2863683004: Disable one more failing feature-policy test + remove [ Crash ] expectation. (Closed)

Created:
3 years, 7 months ago by Łukasz Anforowicz
Modified:
3 years, 7 months ago
Reviewers:
nasko
CC:
chromium-reviews, blink-reviews, lunalu1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable one more failing feature-policy test + remove [ Crash ] expectation. Site Isolation Win FYI bot sees one more failing feature-policy test that needs to be disabled in --site-per-process mode: virtual/feature-policy/http/tests/feature-policy/payment-allowed-by-container-policy-relocate.html Additionally, after r468997 we should no longer need a [ Crash ] expectation for the tests that finish simultaneously in multiple frames. BUG=716085 NOTRY=true TEST=Run all tests covered by the expectations file 10 times. Review-Url: https://codereview.chromium.org/2863683004 Cr-Commit-Position: refs/heads/master@{#469703} Committed: https://chromium.googlesource.com/chromium/src/+/6704e2bcf4ac3f9ecbe7d78378c30f0ec649e6a3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M third_party/WebKit/LayoutTests/FlagExpectations/site-per-process View 1 chunk +12 lines, -12 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Łukasz Anforowicz
nasko@, could you PTAL?
3 years, 7 months ago (2017-05-05 17:20:45 UTC) #2
Łukasz Anforowicz
+lunalu@ FYI
3 years, 7 months ago (2017-05-05 17:21:11 UTC) #3
nasko
LGTM
3 years, 7 months ago (2017-05-05 17:23:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2863683004/1
3 years, 7 months ago (2017-05-05 17:29:57 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-05 17:35:58 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6704e2bcf4ac3f9ecbe7d78378c3...

Powered by Google App Engine
This is Rietveld 408576698