cc: Fix data race in PaintOpBuffer by not mutating PaintOps.

cc: Fix data race in PaintOpBuffer by not mutating PaintOps.

Raster can be done on multiple threads at once, so it is not okay to
mutate a PaintOp while doing raster. This fixes the case of
RasterWithAlpha needing to change the PaintFlags back to having it make
a copy. To do this, we add a RasterWithFlags() static method to each
subclass of PaintOpWithFlags, and call that directly with the modified
flags when needed. These subclasses still need to provide a Raster()
method which just passes the |flags| member thru to the
RasterWithFlags().

Before MonochromePublic.apk: 79,762,639 bytes
After MonochromePublic.apk: 79,762,639 bytes

R=enne@chromium.org
BUG=718309
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2863673002
Cr-Commit-Position: refs/heads/master@{#469450}
Committed: https://chromium.googlesource.com/chromium/src/+/92d629556f9aecd90a2af9785d1a5713dd15b0ba

[danakj, 2017-05-04 17:50:57]

Description was changed from

==========
cc: Fix data race in PaintOpBuffer by not mutating PaintOps.

Raster can be done on multiple threads at once, so it is not okay to
mutate a PaintOp while doing raster. This fixes the case of
RasterWithAlpha needing to change the PaintFlags back to having it make
a copy. To do this, we add a RasterWithFlags() static method to each
subclass of PaintOpWithFlags, and call that directly with the modified
flags when needed. These subclasses still need to provide a Raster()
method which just passes the |flags| member thru to the
RasterWithFlags().

Before MonochromePublic.apk: 79,762,639 bytes
After MonochromePublic.apk: 79,762,639 bytes

R=enne@chromium.org
BUG=718309
==========

to

==========
cc: Fix data race in PaintOpBuffer by not mutating PaintOps.

Raster can be done on multiple threads at once, so it is not okay to
mutate a PaintOp while doing raster. This fixes the case of
RasterWithAlpha needing to change the PaintFlags back to having it make
a copy. To do this, we add a RasterWithFlags() static method to each
subclass of PaintOpWithFlags, and call that directly with the modified
flags when needed. These subclasses still need to provide a Raster()
method which just passes the |flags| member thru to the
RasterWithFlags().

Before MonochromePublic.apk: 79,762,639 bytes
After MonochromePublic.apk: 79,762,639 bytes

R=enne@chromium.org
BUG=718309
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[enne (OOO), 2017-05-04 18:01:15]

lgtm

[danakj, 2017-05-04 19:04:45]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2017-05-04 19:05:28]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 20:29:44]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493924685035810, "parent_rev":
"bd513eeb478c279634ca95af0344d68b0d95853e", "commit_rev":
"92d629556f9aecd90a2af9785d1a5713dd15b0ba"}

[commit-bot: I haz the power, 2017-05-04 20:29:55]

Description was changed from

==========
cc: Fix data race in PaintOpBuffer by not mutating PaintOps.

Raster can be done on multiple threads at once, so it is not okay to
mutate a PaintOp while doing raster. This fixes the case of
RasterWithAlpha needing to change the PaintFlags back to having it make
a copy. To do this, we add a RasterWithFlags() static method to each
subclass of PaintOpWithFlags, and call that directly with the modified
flags when needed. These subclasses still need to provide a Raster()
method which just passes the |flags| member thru to the
RasterWithFlags().

Before MonochromePublic.apk: 79,762,639 bytes
After MonochromePublic.apk: 79,762,639 bytes

R=enne@chromium.org
BUG=718309
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
cc: Fix data race in PaintOpBuffer by not mutating PaintOps.

Raster can be done on multiple threads at once, so it is not okay to
mutate a PaintOp while doing raster. This fixes the case of
RasterWithAlpha needing to change the PaintFlags back to having it make
a copy. To do this, we add a RasterWithFlags() static method to each
subclass of PaintOpWithFlags, and call that directly with the modified
flags when needed. These subclasses still need to provide a Raster()
method which just passes the |flags| member thru to the
RasterWithFlags().

Before MonochromePublic.apk: 79,762,639 bytes
After MonochromePublic.apk: 79,762,639 bytes

R=enne@chromium.org
BUG=718309
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2863673002
Cr-Commit-Position: refs/heads/master@{#469450}
Committed:
https://chromium.googlesource.com/chromium/src/+/92d629556f9aecd90a2af9785d1a...
==========

[commit-bot: I haz the power, 2017-05-04 20:29:56]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/92d629556f9aecd90a2af9785d1a...