Sysroots: Remove a hack that adds gcc 4.6 to ld.so.conf

Sysroots:  Remove a hack that adds gcc 4.6 to ld.so.conf

This CL removes a hack that adds /usr/lib/gcc/x86_64-linux-gnu/4.6 to
ld.so.conf.d/zz_hack.conf.  The only sysroots that exist currently are
Jessie and Trusty which both use gcc 4.8.

This caused the following flags to be passed to the linker:
-L/path/to/chromium/src/build/linux/debian_jessie_amd64-sysroot/usr/lib/gcc/x86_64-linux-gnu/4.6
-Wl,-rpath-link=/path/to/chromium/src/build/linux/debian_jessie_amd64-sysroot/usr/lib/gcc/x86_64-linux-gnu/4.6
While harmless, it is confusing and should be removed.

R=thestig@chromium.org

Review-Url: https://codereview.chromium.org/2863663003
Cr-Commit-Position: refs/heads/master@{#469518}
Committed: https://chromium.googlesource.com/chromium/src/+/a0ca4a353c368fd2ea8da174ae9fe028fff376af

[Tom (Use chromium acct), 2017-05-04 23:04:47]

thestig ptal

[Tom (Use chromium acct), 2017-05-04 23:09:25]

The CQ bit was checked by thomasanderson@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-04 23:10:17]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Lei Zhang, 2017-05-04 23:16:46]

In the CL description, replace
"/usr/local/google/home/thomasanderson/dev/chromium_2/" with
"/path/to/chromium/" ?

[Lei Zhang, 2017-05-04 23:17:12]

lgtm

[commit-bot: I haz the power, 2017-05-04 23:21:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-04 23:21:05]

Dry run: This issue passed the CQ dry run.

[Tom (Use chromium acct), 2017-05-04 23:22:14]

The CQ bit was checked by thomasanderson@google.com

[commit-bot: I haz the power, 2017-05-04 23:23:15]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom (Use chromium acct), 2017-05-04 23:24:30]

Description was changed from

==========
Sysroots:  Remove a hack that adds gcc 4.6 to ld.so.conf

This CL removes a hack that adds /usr/lib/gcc/x86_64-linux-gnu/4.6 to
ld.so.conf.d/zz_hack.conf.  The only sysroots that exist currently are
Jessie and Trusty which both use gcc 4.8.

This caused the following flags to be passed to the linker:
-L/usr/local/google/home/thomasanderson/dev/chromium_2/src/build/linux/debian_jessie_amd64-sysroot/usr/lib/gcc/x86_64-linux-gnu/4.6
-Wl,-rpath-link=/usr/local/google/home/thomasanderson/dev/chromium_2/src/build/linux/debian_jessie_amd64-sysroot/usr/lib/gcc/x86_64-linux-gnu/4.6
While harmless, it is confusing and should be removed.

R=thestig@chromium.org
==========

to

==========
Sysroots:  Remove a hack that adds gcc 4.6 to ld.so.conf

This CL removes a hack that adds /usr/lib/gcc/x86_64-linux-gnu/4.6 to
ld.so.conf.d/zz_hack.conf.  The only sysroots that exist currently are
Jessie and Trusty which both use gcc 4.8.

This caused the following flags to be passed to the linker:
-L/path/to/chromium/src/build/linux/debian_jessie_amd64-sysroot/usr/lib/gcc/x86_64-linux-gnu/4.6
-Wl,-rpath-link=/path/to/chromium/src/build/linux/debian_jessie_amd64-sysroot/usr/lib/gcc/x86_64-linux-gnu/4.6
While harmless, it is confusing and should be removed.

R=thestig@chromium.org
==========

[Tom (Use chromium acct), 2017-05-04 23:24:41]

On 2017/05/04 23:16:46, Lei Zhang wrote:
> In the CL description, replace
> "/usr/local/google/home/thomasanderson/dev/chromium_2/" with
> "/path/to/chromium/" ?

Done.

[commit-bot: I haz the power, 2017-05-04 23:30:21]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493940134955890, "parent_rev":
"a1215009f69ac267d13b072cc2d4c9cda7155fee", "commit_rev":
"a0ca4a353c368fd2ea8da174ae9fe028fff376af"}

[commit-bot: I haz the power, 2017-05-04 23:31:18]

Description was changed from

==========
Sysroots:  Remove a hack that adds gcc 4.6 to ld.so.conf

This CL removes a hack that adds /usr/lib/gcc/x86_64-linux-gnu/4.6 to
ld.so.conf.d/zz_hack.conf.  The only sysroots that exist currently are
Jessie and Trusty which both use gcc 4.8.

This caused the following flags to be passed to the linker:
-L/path/to/chromium/src/build/linux/debian_jessie_amd64-sysroot/usr/lib/gcc/x86_64-linux-gnu/4.6
-Wl,-rpath-link=/path/to/chromium/src/build/linux/debian_jessie_amd64-sysroot/usr/lib/gcc/x86_64-linux-gnu/4.6
While harmless, it is confusing and should be removed.

R=thestig@chromium.org
==========

to

==========
Sysroots:  Remove a hack that adds gcc 4.6 to ld.so.conf

This CL removes a hack that adds /usr/lib/gcc/x86_64-linux-gnu/4.6 to
ld.so.conf.d/zz_hack.conf.  The only sysroots that exist currently are
Jessie and Trusty which both use gcc 4.8.

This caused the following flags to be passed to the linker:
-L/path/to/chromium/src/build/linux/debian_jessie_amd64-sysroot/usr/lib/gcc/x86_64-linux-gnu/4.6
-Wl,-rpath-link=/path/to/chromium/src/build/linux/debian_jessie_amd64-sysroot/usr/lib/gcc/x86_64-linux-gnu/4.6
While harmless, it is confusing and should be removed.

R=thestig@chromium.org

Review-Url: https://codereview.chromium.org/2863663003
Cr-Commit-Position: refs/heads/master@{#469518}
Committed:
https://chromium.googlesource.com/chromium/src/+/a0ca4a353c368fd2ea8da174ae9f...
==========

[commit-bot: I haz the power, 2017-05-04 23:31:19]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a0ca4a353c368fd2ea8da174ae9f...