Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 2863653002: Mark a FirstRunIntegrationTest flaky (Closed)

Created:
3 years, 7 months ago by johnme
Modified:
3 years, 7 months ago
Reviewers:
gone
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Mark a FirstRunIntegrationTest flaky FirstRunIntegrationTest.testDefaultSearchEngine_ShowExisting was recently added by https://codereview.chromium.org/2844323003. However it's been consistently failing on Lollipop Phone Tester, and flakily failing on other Android bots, so this patch disables it. BUG=718461 TBR=dfalcantara NOTRY=true SKIPTREECHECKS=true Review-Url: https://codereview.chromium.org/2863653002 Cr-Commit-Position: refs/heads/master@{#469356} Committed: https://chromium.googlesource.com/chromium/src/+/cbb2753cfb8b54c01b163ef7e443b95a5f570c75

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/firstrun/FirstRunIntegrationTest.java View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2863653002/1
3 years, 7 months ago (2017-05-04 16:30:38 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/cbb2753cfb8b54c01b163ef7e443b95a5f570c75
3 years, 7 months ago (2017-05-04 16:38:40 UTC) #7
findit-for-me
3 years, 7 months ago (2017-05-04 18:10:08 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2858213003/ by
findit-for-me@appspot.gserviceaccount.com.

The reason for reverting is: 
Findit (https://goo.gl/kROfz5) identified CL at revision 469356 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb....

Powered by Google App Engine
This is Rietveld 408576698