ash: Instantiate UserActivityForwarder for --mus.

ash: Instantiate UserActivityForwarder for --mus.

This class forwards user activity from ws to the
pre-servicification activity-handling mechanism, so it needs
to be used for --mus in addition to --mash. Check for
aura::Env::Mode::MUS to handle both modes.

BUG=717681
TEST=put --mus, --mash, and neither in /etc/chrome_dev.conf
     and check that user activity is reported in
     /var/log/power_manager/powerd.LATEST after hitting a
     key

Review-Url: https://codereview.chromium.org/2863623005
Cr-Commit-Position: refs/heads/master@{#469546}
Committed: https://chromium.googlesource.com/chromium/src/+/036f91b9734b64b10996ea894eb863dd2d66657d

[Daniel Erat, 2017-05-04 23:06:41]

The CQ bit was checked by derat@chromium.org to run a CQ dry run

[Daniel Erat, 2017-05-04 23:06:53]

derat@chromium.org changed reviewers:
+ jamescook@chromium.org

[Daniel Erat, 2017-05-04 23:06:53]

https://codereview.chromium.org/2863623005/diff/1/ash/shell.cc
File ash/shell.cc (right):

https://codereview.chromium.org/2863623005/diff/1/ash/shell.cc#newcode987
ash/shell.cc:987: if ((config == Config::MASH || config == Config::MUS) &&
would you recommend != Config::CLASSIC here? i'm just thinking of the case where
we decide to add yet another /m[aeiou]sh?/ config that uses ws.

[commit-bot: I haz the power, 2017-05-04 23:07:43]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2017-05-04 23:09:48]

https://codereview.chromium.org/2863623005/diff/1/ash/shell.cc
File ash/shell.cc (right):

https://codereview.chromium.org/2863623005/diff/1/ash/shell.cc#newcode987
ash/shell.cc:987: if ((config == Config::MASH || config == Config::MUS) &&
On 2017/05/04 23:06:53, Daniel Erat wrote:
> would you recommend != Config::CLASSIC here? i'm just thinking of the case
where
> we decide to add yet another /m[aeiou]sh?/ config that uses ws.

Maybe we should use aura::Env::Mode::MUS for this sort of thing (i.e. as long as
we are using mus, we would want this, regardless of which mus-config we are
using)?

[Daniel Erat, 2017-05-04 23:56:51]

Description was changed from

==========
ash: Instantiate UserActivityForwarder for Config::MUS.

This class forwards user activity from ws to the
pre-servicification activity-handling mechanism, so it needs
to be used for Config::MUS in addition to Config::MASH.

BUG=717681
TEST=put --mus in /etc/chrome_dev.conf and check that user
     activity is reported in
     /var/log/power_manager/powerd.LATEST after hitting a
     key
==========

to

==========
ash: Instantiate UserActivityForwarder for --mus.

This class forwards user activity from ws to the
pre-servicification activity-handling mechanism, so it needs
to be used for --mus in addition to --mash. Check for
aura::Env::Mode::MUS to handle both modes.

BUG=717681
TEST=put --mus in /etc/chrome_dev.conf and check that user
     activity is reported in
     /var/log/power_manager/powerd.LATEST after hitting a
     key
==========

[Daniel Erat, 2017-05-04 23:57:26]

Description was changed from

==========
ash: Instantiate UserActivityForwarder for --mus.

This class forwards user activity from ws to the
pre-servicification activity-handling mechanism, so it needs
to be used for --mus in addition to --mash. Check for
aura::Env::Mode::MUS to handle both modes.

BUG=717681
TEST=put --mus in /etc/chrome_dev.conf and check that user
     activity is reported in
     /var/log/power_manager/powerd.LATEST after hitting a
     key
==========

to

==========
ash: Instantiate UserActivityForwarder for --mus.

This class forwards user activity from ws to the
pre-servicification activity-handling mechanism, so it needs
to be used for --mus in addition to --mash. Check for
aura::Env::Mode::MUS to handle both modes.

BUG=717681
TEST=put --mus, --mash, and neither in /etc/chrome_dev.conf
     and check that user activity is reported in
     /var/log/power_manager/powerd.LATEST after hitting a
     key
==========

[Daniel Erat, 2017-05-04 23:57:59]

derat@chromium.org changed reviewers:
+ sky@chromium.org

[Daniel Erat, 2017-05-04 23:58:00]

https://codereview.chromium.org/2863623005/diff/1/ash/shell.cc
File ash/shell.cc (right):

https://codereview.chromium.org/2863623005/diff/1/ash/shell.cc#newcode987
ash/shell.cc:987: if ((config == Config::MASH || config == Config::MUS) &&
On 2017/05/04 23:09:48, sadrul wrote:
> On 2017/05/04 23:06:53, Daniel Erat wrote:
> > would you recommend != Config::CLASSIC here? i'm just thinking of the case
> where
> > we decide to add yet another /m[aeiou]sh?/ config that uses ws.
> 
> Maybe we should use aura::Env::Mode::MUS for this sort of thing (i.e. as long
as
> we are using mus, we would want this, regardless of which mus-config we are
> using)?

sure, that seems even better. thanks!

[Daniel Erat, 2017-05-04 23:58:48]

The CQ bit was checked by derat@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-04 23:58:54]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sky, 2017-05-05 00:01:24]

LGTM

[Daniel Erat, 2017-05-05 00:02:58]

The CQ bit was unchecked by derat@chromium.org

[Daniel Erat, 2017-05-05 00:03:02]

The CQ bit was checked by derat@chromium.org

[commit-bot: I haz the power, 2017-05-05 00:03:58]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-05 00:33:21]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493942582234480,
"parent_rev": "e8422c6b6f2255f3f6ad8620af456d8eba0cd9d2", "commit_rev":
"036f91b9734b64b10996ea894eb863dd2d66657d"}

[commit-bot: I haz the power, 2017-05-05 00:34:24]

Description was changed from

==========
ash: Instantiate UserActivityForwarder for --mus.

This class forwards user activity from ws to the
pre-servicification activity-handling mechanism, so it needs
to be used for --mus in addition to --mash. Check for
aura::Env::Mode::MUS to handle both modes.

BUG=717681
TEST=put --mus, --mash, and neither in /etc/chrome_dev.conf
     and check that user activity is reported in
     /var/log/power_manager/powerd.LATEST after hitting a
     key
==========

to

==========
ash: Instantiate UserActivityForwarder for --mus.

This class forwards user activity from ws to the
pre-servicification activity-handling mechanism, so it needs
to be used for --mus in addition to --mash. Check for
aura::Env::Mode::MUS to handle both modes.

BUG=717681
TEST=put --mus, --mash, and neither in /etc/chrome_dev.conf
     and check that user activity is reported in
     /var/log/power_manager/powerd.LATEST after hitting a
     key

Review-Url: https://codereview.chromium.org/2863623005
Cr-Commit-Position: refs/heads/master@{#469546}
Committed:
https://chromium.googlesource.com/chromium/src/+/036f91b9734b64b10996ea894eb8...
==========

[commit-bot: I haz the power, 2017-05-05 00:34:25]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/036f91b9734b64b10996ea894eb8...