Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 2863523003: [Android] Enable test results presentation for gtests in chromium.android.json. (Closed)

Created:
3 years, 7 months ago by BigBossZhiling
Modified:
3 years, 7 months ago
Reviewers:
jbudorick
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Enable test_results_presentation for gtests in chromium.android.json. BUG=717417 Review-Url: https://codereview.chromium.org/2863523003 Cr-Commit-Position: refs/heads/master@{#469223} Committed: https://chromium.googlesource.com/chromium/src/+/e386fce74fe94b6de3645c64e2dbe81fc96e7690

Patch Set 1 #

Total comments: 9

Patch Set 2 : fix change names #

Unified diffs Side-by-side diffs Delta from patch set Stats (+819 lines, -0 lines) Patch
M testing/buildbot/chromium.android.json View 1 91 chunks +819 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
BigBossZhiling
on android n5x swarming
3 years, 7 months ago (2017-05-03 21:59:33 UTC) #3
jbudorick
As mentioned offline, please make the CL subject a bit more descriptive. https://codereview.chromium.org/2863523003/diff/1/testing/buildbot/chromium.android.json File testing/buildbot/chromium.android.json ...
3 years, 7 months ago (2017-05-03 22:17:44 UTC) #4
BigBossZhiling
https://codereview.chromium.org/2863523003/diff/1/testing/buildbot/chromium.android.json File testing/buildbot/chromium.android.json (right): https://codereview.chromium.org/2863523003/diff/1/testing/buildbot/chromium.android.json#newcode3802 testing/buildbot/chromium.android.json:3802: "components_browsertests" On 2017/05/03 22:17:44, jbudorick wrote: > browser_side_navigation_components_browsertests Done. ...
3 years, 7 months ago (2017-05-03 23:05:53 UTC) #6
jbudorick
lgtm Description nit: the second sentence is unnecessary here, as the android bots aren't moving ...
3 years, 7 months ago (2017-05-03 23:08:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2863523003/20001
3 years, 7 months ago (2017-05-03 23:14:37 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 01:07:55 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e386fce74fe94b6de3645c64e2db...

Powered by Google App Engine
This is Rietveld 408576698