Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 2863523002: [Cleanup] Use IsStandaloneExtensionProcess in ChromeContentRendererClient::ShouldGatherSiteIsolatio… (Closed)

Created:
3 years, 7 months ago by karandeepb
Modified:
3 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Cleanup] Use IsStandaloneExtensionProcess in ChromeContentRendererClient::ShouldGatherSiteIsolationStats() BUG=None Review-Url: https://codereview.chromium.org/2863523002 Cr-Commit-Position: refs/heads/master@{#469279} Committed: https://chromium.googlesource.com/chromium/src/+/d5cfef325a0c18b56d8f0f9423f79765a1faa20b

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M chrome/renderer/chrome_content_renderer_client.cc View 1 chunk +1 line, -2 lines 2 comments Download

Messages

Total messages: 9 (4 generated)
karandeepb
PTAL sky@.
3 years, 7 months ago (2017-05-03 21:38:50 UTC) #2
sky
LGTM https://codereview.chromium.org/2863523002/diff/1/chrome/renderer/chrome_content_renderer_client.cc File chrome/renderer/chrome_content_renderer_client.cc (left): https://codereview.chromium.org/2863523002/diff/1/chrome/renderer/chrome_content_renderer_client.cc#oldcode1320 chrome/renderer/chrome_content_renderer_client.cc:1320: base::CommandLine* command_line = base::CommandLine::ForCurrentProcess(); if the command_line include ...
3 years, 7 months ago (2017-05-04 02:55:23 UTC) #3
karandeepb
https://codereview.chromium.org/2863523002/diff/1/chrome/renderer/chrome_content_renderer_client.cc File chrome/renderer/chrome_content_renderer_client.cc (left): https://codereview.chromium.org/2863523002/diff/1/chrome/renderer/chrome_content_renderer_client.cc#oldcode1320 chrome/renderer/chrome_content_renderer_client.cc:1320: base::CommandLine* command_line = base::CommandLine::ForCurrentProcess(); On 2017/05/04 02:55:23, sky wrote: ...
3 years, 7 months ago (2017-05-04 05:05:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2863523002/1
3 years, 7 months ago (2017-05-04 05:05:48 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 05:46:18 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d5cfef325a0c18b56d8f0f9423f7...

Powered by Google App Engine
This is Rietveld 408576698