ui: Change DrawDashedRect to use a dash effect instead of bitmap.

ui: Change DrawDashedRect to use a dash effect instead of bitmap.

This patch changes the draw dash rect to use SkDashPathEffect instead
of a bitmap shader to produce a dash effect. The visual result is
different, but I think it's still acceptable. Please take a look
at the referenced bug for the list of comparison.

R=danakj@chromium.org, enne@chromium.org
BUG=718084
Review-Url: https://codereview.chromium.org/2863453002
Cr-Commit-Position: refs/heads/master@{#469357}
Committed: https://chromium.googlesource.com/chromium/src/+/519f83ea3b9d9d99fb1057f2d388fd3d834545f3

[vmpstr, 2017-05-03 17:21:40]

Description was changed from

==========
ui: Change DrawDashedRect to use a dash effect instead of bitmap.

This patch changes the draw dash rect to use SkDashPathEffect instead
of a bitmap shader to produce a dash effect. The visual result is
different, but I think it's still acceptable. Please take a look
at the referenced bug for the list of comparison.

R=danakj@chromium.org, enne@chromium.org
BUG=
==========

to

==========
ui: Change DrawDashedRect to use a dash effect instead of bitmap.

This patch changes the draw dash rect to use SkDashPathEffect instead
of a bitmap shader to produce a dash effect. The visual result is
different, but I think it's still acceptable. Please take a look
at the referenced bug for the list of comparison.

R=danakj@chromium.org, enne@chromium.org
BUG=718084
==========

[vmpstr, 2017-05-03 17:22:11]

Please take a look (the referenced bug has images for comparison)

[danakj, 2017-05-03 17:32:29]

LGTM

[vmpstr, 2017-05-03 20:59:29]

Changed the code a bit after a discussion with enne, with new results uploaded
to the bug. PTAL.

[enne (OOO), 2017-05-03 21:50:45]

lgtm 2

I think this second approach looks better than the first because of the symmetry
and that higher scales look better than in the original.

[danakj, 2017-05-03 22:43:47]

1.5 is a definite improvement, thanks.

[vmpstr, 2017-05-04 15:36:52]

The CQ bit was checked by vmpstr@chromium.org

[vmpstr, 2017-05-04 15:36:53]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org
Link to the patchset: https://codereview.chromium.org/2863453002/#ps20001
(title: "asd")

[commit-bot: I haz the power, 2017-05-04 15:37:11]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 16:39:02]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493912212978170,
"parent_rev": "cbb2753cfb8b54c01b163ef7e443b95a5f570c75", "commit_rev":
"519f83ea3b9d9d99fb1057f2d388fd3d834545f3"}

[commit-bot: I haz the power, 2017-05-04 16:39:09]

Description was changed from

==========
ui: Change DrawDashedRect to use a dash effect instead of bitmap.

This patch changes the draw dash rect to use SkDashPathEffect instead
of a bitmap shader to produce a dash effect. The visual result is
different, but I think it's still acceptable. Please take a look
at the referenced bug for the list of comparison.

R=danakj@chromium.org, enne@chromium.org
BUG=718084
==========

to

==========
ui: Change DrawDashedRect to use a dash effect instead of bitmap.

This patch changes the draw dash rect to use SkDashPathEffect instead
of a bitmap shader to produce a dash effect. The visual result is
different, but I think it's still acceptable. Please take a look
at the referenced bug for the list of comparison.

R=danakj@chromium.org, enne@chromium.org
BUG=718084

Review-Url: https://codereview.chromium.org/2863453002
Cr-Commit-Position: refs/heads/master@{#469357}
Committed:
https://chromium.googlesource.com/chromium/src/+/519f83ea3b9d9d99fb1057f2d388...
==========

[commit-bot: I haz the power, 2017-05-04 16:39:10]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/519f83ea3b9d9d99fb1057f2d388...