Implement and ship PushManager.supportedContentEncodings

third_party/WebKit/Source/modules/push_messaging/ServiceWorkerRegistrationPush.idl

Index: third_party/WebKit/Source/modules/push_messaging/ServiceWorkerRegistrationPush.idl
diff --git a/third_party/WebKit/Source/modules/push_messaging/ServiceWorkerRegistrationPush.idl b/third_party/WebKit/Source/modules/push_messaging/ServiceWorkerRegistrationPush.idl
index 06e1cfd082b3ed50ff5270763660c4b088424c22..ad896d7d1e95711f9c8f8ea29db17de9db850f2d 100644
--- a/third_party/WebKit/Source/modules/push_messaging/ServiceWorkerRegistrationPush.idl
+++ b/third_party/WebKit/Source/modules/push_messaging/ServiceWorkerRegistrationPush.idl
@@ -5,7 +5,7 @@
 // https://w3c.github.io/push-api/#extensions-to-the-serviceworkerregistration-interface
 
 [
-    Exposed=(Window, ServiceWorker),
+    Exposed=(Window,Worker),

[johnme, 2017/05/08 14:36:16]

Oddly, pushManager was already exposed on ServiceWorkerRegistration in
webexposed/global-interface-listing-dedicated-worker-expected.txt. Perhaps
Exposed on partial interfaces doesn't do anything? If so consider removing it
and/or replacing it with a comment.

[Peter Beverloo, 2017/05/08 15:00:11]

IDLCompiler.md details that due to the way we implement partial interfaces
(basically merging it), a subset of interface-level annotations will be migrated
to the individual members. [Exposed] is not part of that, so based on that,
proven by it being in that file, implies that it's indeed the case.

However, per the WebIDL spec, having [Exposed] on a partial interface is
perfectly fine, so we should keep it. I guess we just don't carry it over
because there's no demand for the feature yet. Since it's valid, a comment feels
fragile since it'd bound to go out of date when this does get implemented.

[johnme, 2017/05/08 15:09:27]

Ok. Mind filing a bug to mark ServiceWorkerRegistrationNotifications.idl and
ServiceWorkerRegistrationSync.idl as exposed on (Window,Worker) as well?

[Peter Beverloo, 2017/05/08 15:53:15]

https://codereview.chromium.org/2866023003

     RuntimeEnabled=PushMessaging,
 ] partial interface ServiceWorkerRegistration {
     readonly attribute PushManager pushManager;