Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: third_party/WebKit/Source/modules/push_messaging/PushSubscription.idl

Issue 2863443002: Implement and ship PushManager.supportedContentEncodings (Closed)
Patch Set: Implement and ship PushManager.supportedContentEncodings Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/push_messaging/PushSubscription.idl
diff --git a/third_party/WebKit/Source/modules/push_messaging/PushSubscription.idl b/third_party/WebKit/Source/modules/push_messaging/PushSubscription.idl
index bae659f6588d0becf4553ee8f444a96ff186bb73..5f3c3dd976809a8f531bcf866db7570619aa05df 100644
--- a/third_party/WebKit/Source/modules/push_messaging/PushSubscription.idl
+++ b/third_party/WebKit/Source/modules/push_messaging/PushSubscription.idl
@@ -10,7 +10,7 @@ enum PushEncryptionKeyName {
};
[
- Exposed=(Window,ServiceWorker),
+ Exposed=(Window,Worker),
johnme 2017/05/08 14:36:16 Would it be easy to extend http/tests/push_messagi
Peter Beverloo 2017/05/08 15:00:11 I'd argue in the opposite direction - what do you
johnme 2017/05/08 15:09:27 Fair. The test goes a little further, e.g. exercis
Peter Beverloo 2017/05/08 15:53:15 https://codereview.chromium.org/2869793003/
RuntimeEnabled=PushMessaging,
] interface PushSubscription {
readonly attribute USVString endpoint;

Powered by Google App Engine
This is Rietveld 408576698