|
|
Created:
3 years, 7 months ago by shend Modified:
3 years, 7 months ago Reviewers:
meade_UTC10 CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionUpdate SameSizeAsComputedStyle to reflect new changes.
SameSizeAsComputedStyle is meant to be tracking the data layout of
ComputedStyle. Recently, we've moved three DataRefs from ComputedStyle
to ComputedStyleBase without updating the size assert. This was a
silent issue because we changed only the layout, not the size.
This patch updates SameSizeAsComputedStyle to reflect the current state
of ComputedStyle.
BUG=628043
Review-Url: https://codereview.chromium.org/2863423002
Cr-Commit-Position: refs/heads/master@{#471092}
Committed: https://chromium.googlesource.com/chromium/src/+/409ff448dc2fdf77c1de19b39cfafd8780066136
Patch Set 1 #Patch Set 2 : Rebase #Messages
Total messages: 26 (22 generated)
shend@chromium.org changed reviewers: + meade@chromium.org
Hi Eddy, PTAL
lgtm
Description was changed from ========== Update SameSizeAsComputedStyle to reflect new changes. SameSizeAsComputedStyle is meant to be tracking the data layout of ComputedStyle. Recently, we've moved two DataRefs from ComputedStyle to ComputedStyleBase without updating the size assert. This was a silent issue because we changed only the layout, not the size. This patch updates SameSizeAsComputedStyle to reflect the current state of ComputedStyle. BUG=628043 ========== to ========== Update SameSizeAsComputedStyle to reflect new changes. SameSizeAsComputedStyle is meant to be tracking the data layout of ComputedStyle. Recently, we've moved three DataRefs from ComputedStyle to ComputedStyleBase without updating the size assert. This was a silent issue because we changed only the layout, not the size. This patch updates SameSizeAsComputedStyle to reflect the current state of ComputedStyle. BUG=628043 ==========
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...) android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...) linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by shend@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from meade@chromium.org Link to the patchset: https://codereview.chromium.org/2863423002/#ps20001 (title: "Rebase")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494540759386690, "parent_rev": "b69e051f0d66a92428423df72843d0d53ccbd6cd", "commit_rev": "409ff448dc2fdf77c1de19b39cfafd8780066136"}
Message was sent while issue was closed.
Description was changed from ========== Update SameSizeAsComputedStyle to reflect new changes. SameSizeAsComputedStyle is meant to be tracking the data layout of ComputedStyle. Recently, we've moved three DataRefs from ComputedStyle to ComputedStyleBase without updating the size assert. This was a silent issue because we changed only the layout, not the size. This patch updates SameSizeAsComputedStyle to reflect the current state of ComputedStyle. BUG=628043 ========== to ========== Update SameSizeAsComputedStyle to reflect new changes. SameSizeAsComputedStyle is meant to be tracking the data layout of ComputedStyle. Recently, we've moved three DataRefs from ComputedStyle to ComputedStyleBase without updating the size assert. This was a silent issue because we changed only the layout, not the size. This patch updates SameSizeAsComputedStyle to reflect the current state of ComputedStyle. BUG=628043 Review-Url: https://codereview.chromium.org/2863423002 Cr-Commit-Position: refs/heads/master@{#471092} Committed: https://chromium.googlesource.com/chromium/src/+/409ff448dc2fdf77c1de19b39cfa... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/409ff448dc2fdf77c1de19b39cfa... |