Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(859)

Issue 2863423002: Update SameSizeAsComputedStyle to reflect new changes. (Closed)

Created:
3 years, 7 months ago by shend
Modified:
3 years, 7 months ago
Reviewers:
meade_UTC10
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Update SameSizeAsComputedStyle to reflect new changes. SameSizeAsComputedStyle is meant to be tracking the data layout of ComputedStyle. Recently, we've moved three DataRefs from ComputedStyle to ComputedStyleBase without updating the size assert. This was a silent issue because we changed only the layout, not the size. This patch updates SameSizeAsComputedStyle to reflect the current state of ComputedStyle. BUG=628043 Review-Url: https://codereview.chromium.org/2863423002 Cr-Commit-Position: refs/heads/master@{#471092} Committed: https://chromium.googlesource.com/chromium/src/+/409ff448dc2fdf77c1de19b39cfafd8780066136

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 26 (22 generated)
shend
Hi Eddy, PTAL
3 years, 7 months ago (2017-05-08 06:03:00 UTC) #2
meade_UTC10
lgtm
3 years, 7 months ago (2017-05-08 06:22:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2863423002/20001
3 years, 7 months ago (2017-05-11 22:14:12 UTC) #23
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 22:30:49 UTC) #26
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/409ff448dc2fdf77c1de19b39cfa...

Powered by Google App Engine
This is Rietveld 408576698