Fix inspector tests for shared libraries.

Fix inspector tests for shared libraries.

This CL prevents problems with library libicui18n.so during execution
inspector tests when component is defined as shared library.

TEST=inspector/*
BUG=

Review-Url: https://codereview.chromium.org/2863383003
Cr-Commit-Position: refs/heads/master@{#45176}
Committed: https://chromium.googlesource.com/v8/v8/+/ab341eab8cd8a81f55fc045fcdc5eb387277290c

[Ilija.Pavlovic1, 2017-05-08 12:40:54]

ilija.pavlovic@imgtec.com changed reviewers:
+ ivica.bogosavljevic@imgtec.com, jochen@chromium.org,
kozyatinskiy@chromium.org, machenbach@chromium.org, yangguo@chromium.org

[Ilija.Pavlovic1, 2017-05-08 12:40:54]

PTAL

[Michael Achenbach, 2017-05-08 13:30:06]

Can you describe in more detail where these problems occur? The component-build
bots we have atm seem to all execute inspector tests without problem...

https://codereview.chromium.org/2863383003/diff/1/test/inspector/BUILD.gn
File test/inspector/BUILD.gn (right):

https://codereview.chromium.org/2863383003/diff/1/test/inspector/BUILD.gn#new...
test/inspector/BUILD.gn:31: if (v8_enable_i18n_support) {
Maybe add is_component_build to the condition if it's only needed in that case?

[Ilija.Pavlovic1, 2017-05-08 13:44:11]

On 2017/05/08 13:30:06, Michael Achenbach wrote:
> Can you describe in more detail where these problems occur? The
component-build
> bots we have atm seem to all execute inspector tests without problem...
> 
> https://codereview.chromium.org/2863383003/diff/1/test/inspector/BUILD.gn
> File test/inspector/BUILD.gn (right):
> 
>
https://codereview.chromium.org/2863383003/diff/1/test/inspector/BUILD.gn#new...
> test/inspector/BUILD.gn:31: if (v8_enable_i18n_support) {
> Maybe add is_component_build to the condition if it's only needed in that
case?

When V8 was build with component shared library, tests for inspector had the
problems.
On our MIPS testboard we could see almost 460 failed tests and all of them had
the same error message:
Here is one example:

---------
Command: out/Release/inspector-test --random-seed=1563245262 --nohard-abort
--nodead-code-elimination --nofold-constants test/inspector/protocol-test.js
test/inspector/debugger/break-on-exception.js

Stderr:
../v8/out/Release/inspector-test: error while loading shared libraries:
libicui18n.so: cannot open shared object file: No such file or directory
----

I tested my solution for this problem and tests for inspector were successful.


Adaptations for test/inspector/BUILD.gn and test/inspector/inspector.gyp are
done according solution for unittests (see
https://codereview.chromium.org/2479863002/ )

[Ilija.Pavlovic1, 2017-05-08 13:51:49]

https://codereview.chromium.org/2863383003/diff/1/test/inspector/BUILD.gn
File test/inspector/BUILD.gn (right):

https://codereview.chromium.org/2863383003/diff/1/test/inspector/BUILD.gn#new...
test/inspector/BUILD.gn:31: if (v8_enable_i18n_support) {
On 2017/05/08 13:30:05, Michael Achenbach wrote:
> Maybe add is_component_build to the condition if it's only needed in that
case?

This is copied from solution for test/unittests/BUILD.gn which solved the same
problem.

[Michael Achenbach, 2017-05-08 13:54:04]

thanks for explaining. lgtm.

[kozy, 2017-05-08 17:33:13]

lgtm

[Ilija.Pavlovic1, 2017-05-09 05:23:52]

The CQ bit was checked by ilija.pavlovic@imgtec.com

[commit-bot: I haz the power, 2017-05-09 05:24:01]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 06:30:17]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1494307432140070, "parent_rev":
"1989713bc3605bab11461c06cec12df3c326b14d", "commit_rev":
"ab341eab8cd8a81f55fc045fcdc5eb387277290c"}

[commit-bot: I haz the power, 2017-05-09 06:30:24]

Description was changed from

==========
Fix inspector tests for shared libraries.

This CL prevents problems with library libicui18n.so during execution
inspector tests when component is defined as shared library.

TEST=inspector/*
BUG=
==========

to

==========
Fix inspector tests for shared libraries.

This CL prevents problems with library libicui18n.so during execution
inspector tests when component is defined as shared library.

TEST=inspector/*
BUG=

Review-Url: https://codereview.chromium.org/2863383003
Cr-Commit-Position: refs/heads/master@{#45176}
Committed:
https://chromium.googlesource.com/v8/v8/+/ab341eab8cd8a81f55fc045fcdc5eb38727...
==========

[commit-bot: I haz the power, 2017-05-09 06:30:25]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/ab341eab8cd8a81f55fc045fcdc5eb38727...

[jochen (gone - plz use gerrit), 2017-05-09 07:19:53]

jochen@chromium.org changed reviewers:
+ ilija.pavlovic@imgtec.com
- Ilija.Pavlovic@imgtec.com

[jochen (gone - plz use gerrit), 2017-05-09 07:19:54]

I implemented a different fix here:
https://chromium-review.googlesource.com/c/500127/

Ilija, can you confirm that this works for you?

[Ilija.Pavlovic1, 2017-05-09 12:22:25]

On 2017/05/09 07:19:54, jochen wrote:
> I implemented a different fix here:
> https://chromium-review.googlesource.com/c/500127/
> 
> Ilija, can you confirm that this works for you?

On our test-boards we still use GYP.
Now, I made build with GN on commit eb64b26f8f272936b7b5a6f3ebe306ea0b329834
([cleanup][wasm][fuzzer] Share code among the different fuzzers.). This is the
commit on which I build my CL.

There was no problem in execution inspector tests, so it seems that my changes
in test/inspector/BUILD.gn was not necessary. I believe that you use GN and this
is the reason why Michael was surprised regarding problems with inspector tests.

Do you still want to test your fix?

[jochen (gone - plz use gerrit), 2017-05-09 12:24:43]

On 2017/05/09 at 12:22:25, Ilija.Pavlovic wrote:
> On 2017/05/09 07:19:54, jochen wrote:
> > I implemented a different fix here:
> > https://chromium-review.googlesource.com/c/500127/
> > 
> > Ilija, can you confirm that this works for you?
> 
> On our test-boards we still use GYP.
> Now, I made build with GN on commit eb64b26f8f272936b7b5a6f3ebe306ea0b329834
([cleanup][wasm][fuzzer] Share code among the different fuzzers.). This is the
commit on which I build my CL.
> 
> There was no problem in execution inspector tests, so it seems that my changes
in test/inspector/BUILD.gn was not necessary. I believe that you use GN and this
is the reason why Michael was surprised regarding problems with inspector tests.
> 
> Do you still want to test your fix?

yeah, I think it's a nice clean-up anyways :)

thanks for testing

[Ilija.Pavlovic1, 2017-05-09 12:32:03]

On 2017/05/09 12:24:43, jochen wrote:
> On 2017/05/09 at 12:22:25, Ilija.Pavlovic wrote:
> > On 2017/05/09 07:19:54, jochen wrote:
> > > I implemented a different fix here:
> > > https://chromium-review.googlesource.com/c/500127/
> > > 
> > > Ilija, can you confirm that this works for you?
> > 
> > On our test-boards we still use GYP.
> > Now, I made build with GN on commit eb64b26f8f272936b7b5a6f3ebe306ea0b329834
> ([cleanup][wasm][fuzzer] Share code among the different fuzzers.). This is the
> commit on which I build my CL.
> > 
> > There was no problem in execution inspector tests, so it seems that my
changes
> in test/inspector/BUILD.gn was not necessary. I believe that you use GN and
this
> is the reason why Michael was surprised regarding problems with inspector
tests.
> > 
> > Do you still want to test your fix?
> 
> yeah, I think it's a nice clean-up anyways :)
> 
> thanks for testing

I noted now that my build was with the flag is_component_build=false :-(
Please, wait for results with is_component_build=true

[Ilija.Pavlovic1, 2017-05-09 13:45:09]

On 2017/05/09 12:32:03, Ilija.Pavlovic1 wrote:
> On 2017/05/09 12:24:43, jochen wrote:
> > On 2017/05/09 at 12:22:25, Ilija.Pavlovic wrote:
> > > On 2017/05/09 07:19:54, jochen wrote:
> > > > I implemented a different fix here:
> > > > https://chromium-review.googlesource.com/c/500127/
> > > > 
> > > > Ilija, can you confirm that this works for you?
> > > 
> > > On our test-boards we still use GYP.
> > > Now, I made build with GN on commit
eb64b26f8f272936b7b5a6f3ebe306ea0b329834
> > ([cleanup][wasm][fuzzer] Share code among the different fuzzers.). This is
the
> > commit on which I build my CL.
> > > 
> > > There was no problem in execution inspector tests, so it seems that my
> changes
> > in test/inspector/BUILD.gn was not necessary. I believe that you use GN and
> this
> > is the reason why Michael was surprised regarding problems with inspector
> tests.
> > > 
> > > Do you still want to test your fix?
> > 
> > yeah, I think it's a nice clean-up anyways :)
> > 
> > thanks for testing
> 
> I noted now that my build was with the flag is_component_build=false :-(
> Please, wait for results with is_component_build=true

When is_component_build=true in all combinations (without this CL, with this CL
and with your fix) inspector tests were successful. For your fix additionally is
tested unittests and it seems that they are also OK.

[jochen (gone - plz use gerrit), 2017-05-09 13:51:44]

thx