DevTools: Support color by Product on timeline flamechart.

DevTools: Support color by Product on timeline flamechart.

The coloring switch is supported for the main flamechart.

BUG=718655
Review-Url: https://codereview.chromium.org/2863293002
Cr-Commit-Position: refs/heads/master@{#470143}
Committed: https://chromium.googlesource.com/chromium/src/+/e8678a7c27bb2e8bb2de032a1039155c5a0be1b2

[alph, 2017-05-06 01:43:17]

alph@chromium.org changed reviewers:
+ caseq@chromium.org

[caseq, 2017-05-08 18:20:35]

lgtm

https://codereview.chromium.org/2863293002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartDataProvider.js
(right):

https://codereview.chromium.org/2863293002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartDataProvider.js:972:
setEntryColorMapping(colorForEvent) {
setEventColorMapping()?

https://codereview.chromium.org/2863293002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartDataProvider.js:974:
this.dispatchEventToListeners(Timeline.TimelineFlameChartDataProvider.Events.DataChanged);
Let's have higher level perform refresh instead.

https://codereview.chromium.org/2863293002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js
(right):

https://codereview.chromium.org/2863293002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js:84:
ProductRegistry.instance().then(registry => this._productRegistry = registry);
Let's make this conditional on experiment.

https://codereview.chromium.org/2863293002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js:119:
if (event.name === TimelineModel.TimelineModel.RecordType.JSFrame) {
if (event.name !== ...)
 return Timeline.TimelineUIUtils.eventStyle(event).category.color;

[alph, 2017-05-08 19:00:20]

https://codereview.chromium.org/2863293002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartDataProvider.js
(right):

https://codereview.chromium.org/2863293002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartDataProvider.js:972:
setEntryColorMapping(colorForEvent) {
On 2017/05/08 18:20:35, caseq wrote:
> setEventColorMapping()?

Done.

https://codereview.chromium.org/2863293002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartDataProvider.js:974:
this.dispatchEventToListeners(Timeline.TimelineFlameChartDataProvider.Events.DataChanged);
On 2017/05/08 18:20:35, caseq wrote:
> Let's have higher level perform refresh instead.

Done.

https://codereview.chromium.org/2863293002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js
(right):

https://codereview.chromium.org/2863293002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js:84:
ProductRegistry.instance().then(registry => this._productRegistry = registry);
On 2017/05/08 18:20:35, caseq wrote:
> Let's make this conditional on experiment.

Done.

https://codereview.chromium.org/2863293002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js:119:
if (event.name === TimelineModel.TimelineModel.RecordType.JSFrame) {
On 2017/05/08 18:20:35, caseq wrote:
> if (event.name !== ...)
>  return Timeline.TimelineUIUtils.eventStyle(event).category.color;

Done.

[alph, 2017-05-08 19:00:23]

The CQ bit was checked by alph@chromium.org

[alph, 2017-05-08 19:00:23]

The patchset sent to the CQ was uploaded after l-g-t-m from caseq@chromium.org
Link to the patchset: https://codereview.chromium.org/2863293002/#ps20001
(title: "addressing comments")

[commit-bot: I haz the power, 2017-05-08 19:01:08]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 22:00:59]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494270023458280,
"parent_rev": "3449c607560559da80f7ecc9c3e5b24440b9010c", "commit_rev":
"e8678a7c27bb2e8bb2de032a1039155c5a0be1b2"}

[commit-bot: I haz the power, 2017-05-08 22:01:07]

Description was changed from

==========
DevTools: Support color by Product on timeline flamechart.

The coloring switch is supported for the main flamechart.

BUG=718655
==========

to

==========
DevTools: Support color by Product on timeline flamechart.

The coloring switch is supported for the main flamechart.

BUG=718655

Review-Url: https://codereview.chromium.org/2863293002
Cr-Commit-Position: refs/heads/master@{#470143}
Committed:
https://chromium.googlesource.com/chromium/src/+/e8678a7c27bb2e8bb2de032a1039...
==========

[commit-bot: I haz the power, 2017-05-08 22:01:08]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e8678a7c27bb2e8bb2de032a1039...