[WebView] Move files from native to browser

[WebView] Move files from native to browser

This patch:
- Moved files from native to broswer mechanically by
using tools/git/move_source_file.py.

- Moved content in //android_webview/native/BUILD.gn to
//android_webview/BUILD.gn.

- Updated //android_webview/test/BUILD.gn for unit tests in
//android_webview/native/.

- Updated corresponding include_rules to //android_webview/broswer/DEPS.

- Contains a lot of formatting from git cl format.

BUG=716604
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2863233002
Cr-Commit-Position: refs/heads/master@{#470203}
Committed: https://chromium.googlesource.com/chromium/src/+/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86

[Shimi Zhang, 2017-05-05 21:26:09]

The CQ bit was checked by ctzsm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-05 21:27:12]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-05 21:43:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-05 21:43:35]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Shimi Zhang, 2017-05-05 23:30:28]

ctzsm@chromium.org changed reviewers:
+ torne@chromium.org

[Shimi Zhang, 2017-05-05 23:30:30]

torne@, PTAL, looks like an XL CL, but most of the changes are made by scripts.

Changes need to be careful are BUILD.gn files and DEPS files.

There are some pre-submit check failure, since I didn't touch the those places,
I think they are already there for a while, want to skip pre-submit check or
wait for actual fix then do a rebase, WDYT?

One of the warnings looks like a false alert to me, the other one says not to
hard code URls, so only paste the errors as follows: (people tagged are based on
git blame)


** Presubmit ERRORS **
Banned functions were used.
tobiasjs@
    android_webview/browser/aw_debug.cc:31:
      New code should not use ScopedAllowIO. Post a task to the blocking
      pool or the FILE thread instead.
  
paulmiller@@
android_webview/browser/aw_metrics_service_client_impl.cc:117:
      Use base/task_scheduler/post_task.h instead of the blocking pool. See
      mapping between both APIs in content/public/browser/browser_thread.h.
      For questions, contact base/task_scheduler/OWNERS.

[Shimi Zhang, 2017-05-06 00:02:58]

The CQ bit was checked by ctzsm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-06 00:04:01]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-06 00:18:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-06 00:18:25]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[gsennton, 2017-05-08 13:12:02]

gsennton@chromium.org changed reviewers:
+ gsennton@chromium.org

[gsennton, 2017-05-08 13:12:04]

https://codereview.chromium.org/2863233002/diff/1/android_webview/BUILD.gn
File android_webview/BUILD.gn (right):

https://codereview.chromium.org/2863233002/diff/1/android_webview/BUILD.gn#ne...
android_webview/BUILD.gn:39: source_set("native") {
Are you planning to merge this with source_set("common") later on?

[Tobias Sargeant, 2017-05-08 13:18:08]

On 2017/05/08 13:12:04, gsennton wrote:
> https://codereview.chromium.org/2863233002/diff/1/android_webview/BUILD.gn
> File android_webview/BUILD.gn (right):
> 
>
https://codereview.chromium.org/2863233002/diff/1/android_webview/BUILD.gn#ne...
> android_webview/BUILD.gn:39: source_set("native") {
> Are you planning to merge this with source_set("common") later on?

IMO it would be better to do this without formatting changes. As the designated
reviewer, that can be Torne's call though.

[Shimi Zhang, 2017-05-08 19:55:53]

On 2017/05/08 13:12:04, gsennton wrote:
> https://codereview.chromium.org/2863233002/diff/1/android_webview/BUILD.gn
> File android_webview/BUILD.gn (right):
> 
>
https://codereview.chromium.org/2863233002/diff/1/android_webview/BUILD.gn#ne...
> android_webview/BUILD.gn:39: source_set("native") {
> Are you planning to merge this with source_set("common") later on?

gsennton@, mostly yes, some files might be merged into browser layer, so they
won't exist anymore.

[Shimi Zhang, 2017-05-08 20:00:07]

On 2017/05/08 13:18:08, Tobias Sargeant wrote:
 
> IMO it would be better to do this without formatting changes. As the
designated
> reviewer, that can be Torne's call though.

SGTM, I checked without formatting, it seems there is no presubmit check errors.

[Shimi Zhang, 2017-05-08 21:08:41]

On 2017/05/08 20:00:07, Shimi Zhang wrote:
> On 2017/05/08 13:18:08, Tobias Sargeant wrote:
>  
> > IMO it would be better to do this without formatting changes. As the
> designated
> > reviewer, that can be Torne's call though.
> 
> SGTM, I checked without formatting, it seems there is no presubmit check
errors.

tobiasjs@, upon the actual git cl upload, there are the same pre-submit check
errors still. Even the formatting didn't change where the pre-submit check
showed if we take a closer look, not sure how exactly did these pre-submit
checks work, looks like not very consistent to git diff.

torne@, We will have less burden without formatting though, WDYT?

[Torne, 2017-05-08 21:47:47]

On 2017/05/08 21:08:41, Shimi Zhang wrote:
> On 2017/05/08 20:00:07, Shimi Zhang wrote:
> > On 2017/05/08 13:18:08, Tobias Sargeant wrote:
> >  
> > > IMO it would be better to do this without formatting changes. As the
> > designated
> > > reviewer, that can be Torne's call though.
> > 
> > SGTM, I checked without formatting, it seems there is no presubmit check
> errors.
> 
> tobiasjs@, upon the actual git cl upload, there are the same pre-submit check
> errors still. Even the formatting didn't change where the pre-submit check
> showed if we take a closer look, not sure how exactly did these pre-submit
> checks work, looks like not very consistent to git diff.
> 
> torne@, We will have less burden without formatting though, WDYT?

Moved files are actually new files per git and so need to be formatted
correctly. If the presubmit on your local machine doesn't match the presubmit on
the server this is unfortunately probably a weird artifact of the way that
rietveld handles patches (it's not really a git commit); it's probably not worth
investigating at this point because we're moving away from rietveld and this
likely won't happen in gerrit (or at least if it still does, that'd be a
separate issue).

There is a third option if you want to do this "tidily": you could just format
all the files first, before moving them. The changes incurred during the move
won't break clang-format, I expect :)

However, the non-formatting related presubmit warnings are not so easily
avoided, and it's probably fine to just leave them alone - this will mean you
can't submit using the CQ though, as it will never allow a change with presubmit
issues to be landed. You'll have to be a committer and land it manually..

The change itself LGTM. I don't think it's super important to separate out the
formatting from this change, but if you can be bothered to do it then doing it
first as I proposed should work ;)

[Torne, 2017-05-08 21:48:15]

https://codereview.chromium.org/2863233002/diff/1/android_webview/BUILD.gn
File android_webview/BUILD.gn (right):

https://codereview.chromium.org/2863233002/diff/1/android_webview/BUILD.gn#ne...
android_webview/BUILD.gn:39: source_set("native") {
On 2017/05/08 13:12:04, gsennton wrote:
> Are you planning to merge this with source_set("common") later on?

Yeah, we should do this, but it can come in a later CL.

[Shimi Zhang, 2017-05-08 23:50:29]

Description was changed from

==========
[WebView] Move files from native to browser

This patch:
- Moved files from native to broswer mechanically by
using tools/git/move_source_file.py.

- Moved content in //android_webview/native/BUILD.gn to
//android_webview/BUILD.gn.

- Updated //android_webview/test/BUILD.gn for unit tests in
//android_webview/native/.

- Updated corresponding include_rules to //android_webview/broswer/DEPS.

- Contains a lot of formatting from git cl format.

BUG=716604
==========

to

==========
[WebView] Move files from native to browser

This patch:
- Moved files from native to broswer mechanically by
using tools/git/move_source_file.py.

- Moved content in //android_webview/native/BUILD.gn to
//android_webview/BUILD.gn.

- Updated //android_webview/test/BUILD.gn for unit tests in
//android_webview/native/.

- Updated corresponding include_rules to //android_webview/broswer/DEPS.

- Contains a lot of formatting from git cl format.

BUG=716604
NOPRESUBMIT=true
==========

[Shimi Zhang, 2017-05-08 23:50:40]

The CQ bit was checked by ctzsm@chromium.org

[Shimi Zhang, 2017-05-09 00:00:08]

The CQ bit was unchecked by ctzsm@chromium.org

[Shimi Zhang, 2017-05-09 00:00:19]

The CQ bit was checked by ctzsm@chromium.org

[commit-bot: I haz the power, 2017-05-09 00:07:24]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Shimi Zhang, 2017-05-09 01:13:37]

On 2017/05/08 21:47:47, Torne wrote:
> On 2017/05/08 21:08:41, Shimi Zhang wrote:
> > On 2017/05/08 20:00:07, Shimi Zhang wrote:
> > > On 2017/05/08 13:18:08, Tobias Sargeant wrote:
> > >  
> > > > IMO it would be better to do this without formatting changes. As the
> > > designated
> > > > reviewer, that can be Torne's call though.
> > > 
> > > SGTM, I checked without formatting, it seems there is no presubmit check
> > errors.
> > 
> > tobiasjs@, upon the actual git cl upload, there are the same pre-submit
check
> > errors still. Even the formatting didn't change where the pre-submit check
> > showed if we take a closer look, not sure how exactly did these pre-submit
> > checks work, looks like not very consistent to git diff.
> > 
> > torne@, We will have less burden without formatting though, WDYT?
> 
> Moved files are actually new files per git and so need to be formatted
> correctly. If the presubmit on your local machine doesn't match the presubmit
on
> the server this is unfortunately probably a weird artifact of the way that
> rietveld handles patches (it's not really a git commit); it's probably not
worth
> investigating at this point because we're moving away from rietveld and this
> likely won't happen in gerrit (or at least if it still does, that'd be a
> separate issue).

Run git cl presubmit gave me different result from git cl upload in this case.
> 
> There is a third option if you want to do this "tidily": you could just format
> all the files first, before moving them. The changes incurred during the move
> won't break clang-format, I expect :)
> 
> However, the non-formatting related presubmit warnings are not so easily
> avoided, and it's probably fine to just leave them alone - this will mean you
> can't submit using the CQ though, as it will never allow a change with
presubmit
> issues to be landed. You'll have to be a committer and land it manually..

I am trying to use NOPRESUBMIT=true to see if that works, if not, will try this
option. Thanks! :)
> 
> The change itself LGTM. I don't think it's super important to separate out the
> formatting from this change, but if you can be bothered to do it then doing it
> first as I proposed should work ;)

[commit-bot: I haz the power, 2017-05-09 01:21:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-09 01:21:56]

Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[Shimi Zhang, 2017-05-09 01:24:39]

The CQ bit was checked by ctzsm@chromium.org

[commit-bot: I haz the power, 2017-05-09 01:26:00]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 04:27:41]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1494293079485480, "parent_rev":
"3248f4867e7ac406e88ac458ae1d34c168506636", "commit_rev":
"0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86"}

[commit-bot: I haz the power, 2017-05-09 04:27:49]

Description was changed from

==========
[WebView] Move files from native to browser

This patch:
- Moved files from native to broswer mechanically by
using tools/git/move_source_file.py.

- Moved content in //android_webview/native/BUILD.gn to
//android_webview/BUILD.gn.

- Updated //android_webview/test/BUILD.gn for unit tests in
//android_webview/native/.

- Updated corresponding include_rules to //android_webview/broswer/DEPS.

- Contains a lot of formatting from git cl format.

BUG=716604
NOPRESUBMIT=true
==========

to

==========
[WebView] Move files from native to browser

This patch:
- Moved files from native to broswer mechanically by
using tools/git/move_source_file.py.

- Moved content in //android_webview/native/BUILD.gn to
//android_webview/BUILD.gn.

- Updated //android_webview/test/BUILD.gn for unit tests in
//android_webview/native/.

- Updated corresponding include_rules to //android_webview/broswer/DEPS.

- Contains a lot of formatting from git cl format.

BUG=716604
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2863233002
Cr-Commit-Position: refs/heads/master@{#470203}
Committed:
https://chromium.googlesource.com/chromium/src/+/0baa01dcbb179dd9c4ede2ceeff2...
==========

[commit-bot: I haz the power, 2017-05-09 04:27:51]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0baa01dcbb179dd9c4ede2ceeff2...