Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issue 2863173002: [Sync] Switch ModelTypeStore* from blocking pool to post_task.h (Closed)

Created:
3 years, 7 months ago by skym
Modified:
3 years, 7 months ago
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, marq+watch_chromium.org, stkhapugin, sync-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Switch ModelTypeStore* from blocking pool to post_task.h BUG=718974 Review-Url: https://codereview.chromium.org/2863173002 Cr-Commit-Position: refs/heads/master@{#470334} Committed: https://chromium.googlesource.com/chromium/src/+/7991ed9aaa1c6c0ff7faf13153503aa5819efa31

Patch Set 1 #

Patch Set 2 : Self review. #

Messages

Total messages: 22 (12 generated)
skym
PTAL
3 years, 7 months ago (2017-05-05 18:43:44 UTC) #3
pavely
lgtm
3 years, 7 months ago (2017-05-05 20:54:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2863173002/20001
3 years, 7 months ago (2017-05-05 21:51:44 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/428894)
3 years, 7 months ago (2017-05-05 22:06:51 UTC) #11
skym
+olivierrobin for reading list, +skau for printers
3 years, 7 months ago (2017-05-05 22:42:20 UTC) #13
skau
lgtm printers
3 years, 7 months ago (2017-05-05 22:56:11 UTC) #14
skym
+noyau@ for reading list, seems olivierrobin@ may be ooo.
3 years, 7 months ago (2017-05-08 13:28:13 UTC) #16
noyau (Ping after 24h)
reading_list lgtm
3 years, 7 months ago (2017-05-09 13:14:00 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2863173002/20001
3 years, 7 months ago (2017-05-09 13:14:48 UTC) #19
commit-bot: I haz the power
3 years, 7 months ago (2017-05-09 15:01:02 UTC) #22
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7991ed9aaa1c6c0ff7faf1315350...

Powered by Google App Engine
This is Rietveld 408576698