Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 2863163003: Add nacl_loader_manifest to catalog_mus. (Closed)

Created:
3 years, 7 months ago by Hadi
Modified:
3 years, 7 months ago
Reviewers:
sadrul, sky
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add nacl_loader_manifest to catalog_mus. This is to make NaCl input method extensions (e.g. Chinese Pinyin input method) work in --mus. BUG=718953 Review-Url: https://codereview.chromium.org/2863163003 Cr-Commit-Position: refs/heads/master@{#469806} Committed: https://chromium.googlesource.com/chromium/src/+/f516fb4fdfbf82b040b59b1dbc753030a89a1637

Patch Set 1 #

Patch Set 2 : remove nacl_broker_manifest until its needed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/app/mash/BUILD.gn View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
Hadi
PTAL. Thanks.
3 years, 7 months ago (2017-05-05 19:20:23 UTC) #3
sky
LGTM
3 years, 7 months ago (2017-05-05 23:15:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2863163003/20001
3 years, 7 months ago (2017-05-05 23:34:17 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-05 23:44:26 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f516fb4fdfbf82b040b59b1dbc75...

Powered by Google App Engine
This is Rietveld 408576698