Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2863133002: Disable 4 failing StackSamplingProfilerTest tests on macOS ASAN. (Closed)

Created:
3 years, 7 months ago by johnme
Modified:
3 years, 7 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, danakj+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable 4 failing StackSamplingProfilerTest tests on macOS ASAN. The {Alloca,Basic,UnloadedLibrary,OtherLibrary} tests from StackSamplingProfilerTest are failing since https://codereview.chromium.org/2848683006 because ASAN wraps the kernel dylib on macOS. This patch disables them for now on macOS ASAN. BUG=718628 TBR=avi@chromium.org NOTRY=true SKIPTREECHECKS=true Review-Url: https://codereview.chromium.org/2863133002 Cr-Commit-Position: refs/heads/master@{#469648} Committed: https://chromium.googlesource.com/chromium/src/+/20352c4f2055a99e8df8b0ab75b8b54f79cebc77

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M base/profiler/stack_sampling_profiler_unittest.cc View 4 chunks +12 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2863133002/1
3 years, 7 months ago (2017-05-05 14:46:03 UTC) #4
commit-bot: I haz the power
3 years, 7 months ago (2017-05-05 14:51:44 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/20352c4f2055a99e8df8b0ab75b8...

Powered by Google App Engine
This is Rietveld 408576698