Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 2863083002: Avoid duplicating the BleedAvoidanceIsClipping function in Blink paint (Closed)

Created:
3 years, 7 months ago by Daniel Bratell
Modified:
3 years, 7 months ago
Reviewers:
f(malita)
CC:
chromium-reviews, pdr+renderingwatchlist_chromium.org, zoltan1, blink-reviews-layout_chromium.org, szager+layoutwatch_chromium.org, eae+blinkwatch, leviw+renderwatch, dshwang, jchaffraix+rendering, blink-reviews-paint_chromium.org, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid duplicating the BleedAvoidanceIsClipping function in Blink paint There were two copies of BleedAvoidanceIsClipping and that is not what we want. I noticed this while experimenting with jumbo builds where the two identical symbols would collide. Review-Url: https://codereview.chromium.org/2863083002 Cr-Commit-Position: refs/heads/master@{#469951} Committed: https://chromium.googlesource.com/chromium/src/+/7b25452790cbea67af535d523b49bcd60e0afe56

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -14 lines) Patch
M third_party/WebKit/Source/core/layout/BackgroundBleedAvoidance.h View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/BoxBorderPainter.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/paint/BoxPainter.cpp View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Daniel Bratell
fmalita, please take a look. Maybe you know an even better place to put the ...
3 years, 7 months ago (2017-05-05 11:48:43 UTC) #5
f(malita)
Thanks, LGTM.
3 years, 7 months ago (2017-05-05 21:25:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2863083002/1
3 years, 7 months ago (2017-05-08 07:13:55 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-08 10:31:29 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7b25452790cbea67af535d523b49...

Powered by Google App Engine
This is Rietveld 408576698