Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(713)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2863073003: Access NativeData only through ClosedWorld (Closed)

Created:
3 years, 7 months ago by Johnni Winther
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+175 lines, -110 lines) Patch
M pkg/compiler/lib/src/inferrer/inferrer_engine.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/inferrer/type_graph_nodes.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 5 chunks +9 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend_serialization.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/frequency_namer.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/minify_namer.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/namer.dart View 3 chunks +3 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/native_data.dart View 6 chunks +81 lines, -19 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/code_emitter_task.dart View 5 chunks +9 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart View 5 chunks +11 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/interceptor_emitter.dart View 2 chunks +0 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/interceptor_stub_generator.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/native_emitter.dart View 3 chunks +2 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart View 3 chunks +0 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/kernel/element_map.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/native/behavior.dart View 7 chunks +9 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/codegen.dart View 5 chunks +2 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/ssa/graph_builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/types/types.dart View 4 chunks +4 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/universe/element_world_builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/jsinterop/world_test.dart View 1 chunk +20 lines, -20 lines 0 comments Download
M tests/compiler/dart2js/serialization/native_data_test.dart View 3 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 7 months ago (2017-05-05 11:57:47 UTC) #2
Siggi Cherem (dart-lang)
lgtm
3 years, 7 months ago (2017-05-05 18:06:44 UTC) #3
Johnni Winther
3 years, 7 months ago (2017-05-08 09:28:29 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
074baf1b9af7f4afda688724f9e188f9731a9fe8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698