Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1383)

Unified Diff: pkg/compiler/lib/src/js_backend/backend.dart

Issue 2863073003: Access NativeData only through ClosedWorld (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_backend/backend.dart
diff --git a/pkg/compiler/lib/src/js_backend/backend.dart b/pkg/compiler/lib/src/js_backend/backend.dart
index 1c5d7132d0d12c752d21bd00790cb457a3d6f5ec..78a8ecdb20de1818cea89015f1c07b7369f31db0 100644
--- a/pkg/compiler/lib/src/js_backend/backend.dart
+++ b/pkg/compiler/lib/src/js_backend/backend.dart
@@ -434,12 +434,12 @@ class JavaScriptBackend {
/// Interface for serialization of backend specific data.
JavaScriptBackendSerialization serialization;
- NativeDataImpl _nativeData;
+ NativeDataBuilderImpl _nativeDataBuilder;
final NativeBasicDataBuilderImpl _nativeBasicDataBuilder =
new NativeBasicDataBuilderImpl();
NativeBasicDataImpl _nativeBasicData;
- NativeData get nativeData => _nativeData;
- NativeDataBuilder get nativeDataBuilder => _nativeData;
+ //NativeData get nativeData => _nativeData;
+ NativeDataBuilder get nativeDataBuilder => _nativeDataBuilder;
final NativeDataResolver _nativeDataResolver;
InterceptorDataBuilder _interceptorDataBuilder;
InterceptorData _interceptorData;
@@ -695,10 +695,9 @@ class JavaScriptBackend {
ClosedWorld closedWorld, CodegenWorldBuilder codegenWorldBuilder) {
return compiler.options.enableMinification
? compiler.options.useFrequencyNamer
- ? new FrequencyBasedNamer(
- nativeData, closedWorld, codegenWorldBuilder)
- : new MinifyNamer(nativeData, closedWorld, codegenWorldBuilder)
- : new Namer(nativeData, closedWorld, codegenWorldBuilder);
+ ? new FrequencyBasedNamer(closedWorld, codegenWorldBuilder)
+ : new MinifyNamer(closedWorld, codegenWorldBuilder)
+ : new Namer(closedWorld, codegenWorldBuilder);
}
/// Returns true if global optimizations such as type inferencing can apply to
@@ -848,7 +847,7 @@ class JavaScriptBackend {
commonElements,
backendUsageBuilder,
compiler.frontEndStrategy.createNativeClassFinder(nativeBasicData));
- _nativeData = new NativeDataImpl(nativeBasicData);
+ _nativeDataBuilder = new NativeDataBuilderImpl(nativeBasicData);
_customElementsResolutionAnalysis = compiler.frontEndStrategy
.createCustomElementsResolutionAnalysis(
nativeBasicData, backendUsageBuilder);
@@ -917,7 +916,7 @@ class JavaScriptBackend {
commonElements,
emitter,
_nativeResolutionEnqueuer,
- nativeData);
+ closedWorld.nativeData);
return new CodegenEnqueuer(
task,
compiler.options,
@@ -1156,7 +1155,7 @@ class JavaScriptBackend {
commonElements,
impacts,
checkedModeHelpers,
- nativeData,
+ closedWorld.nativeData,
backendUsage,
rtiNeed,
nativeCodegenEnqueuer,
« no previous file with comments | « pkg/compiler/lib/src/inferrer/type_graph_nodes.dart ('k') | pkg/compiler/lib/src/js_backend/backend_serialization.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698