content/public/android/junit/src/org/chromium/content/browser/BindingManagerImplTest.java - Issue 2863063002: Making ChildConnectionAllocator simpler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/junit/src/org/chromium/content/browser/BindingManagerImplTest.java

Issue 2863063002: Making ChildConnectionAllocator simpler. (Closed)

Patch Set: Fixed tests. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/android/java/src/org/chromium/content/browser/BindingManagerImpl.java ('K') | « content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherTest.java ('k') | content/public/test/android/javatests/src/org/chromium/content/browser/test/ChildProcessAllocatorSettingsHook.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/junit/src/org/chromium/content/browser/BindingManagerImplTest.java

diff --git a/content/public/android/junit/src/org/chromium/content/browser/BindingManagerImplTest.java b/content/public/android/junit/src/org/chromium/content/browser/BindingManagerImplTest.java

index dad88d10646eac4f579a4bd379b52ca70666304f..e15e7f13e1ed146cfd9dbbc177df999121211bae 100644

--- a/content/public/android/junit/src/org/chromium/content/browser/BindingManagerImplTest.java

+++ b/content/public/android/junit/src/org/chromium/content/browser/BindingManagerImplTest.java

@@ -67,7 +67,7 @@ public class BindingManagerImplTest {

* connection is established: with initial binding bound and no strong binding.

private TestChildProcessConnection(int pid) {

- super(null /* context */, true /* sandboxed */, null /* deathCallback */,

+ super(null /* context */, null /* deathCallback */,

"TestService" /* serviceClassName */, null /* childProcessCommonParameters */,

new ChildProcessCreationParams("org.chromium.test",

false /* isExternalService */, 0 /* libraryProcessType */,