Making ChildConnectionAllocator simpler.

content/public/android/java/src/org/chromium/content/browser/BindingManagerImpl.java

Index: content/public/android/java/src/org/chromium/content/browser/BindingManagerImpl.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/BindingManagerImpl.java b/content/public/android/java/src/org/chromium/content/browser/BindingManagerImpl.java
index 6ddbe86daf7f62acd58ad885d0fb9f2ccbde82cd..c6aa88c4aa7dd935759073ad635c1f7778d9f241 100644
--- a/content/public/android/java/src/org/chromium/content/browser/BindingManagerImpl.java
+++ b/content/public/android/java/src/org/chromium/content/browser/BindingManagerImpl.java
@@ -99,21 +99,16 @@ class BindingManagerImpl implements BindingManager {
         }
 
         void addConnection(ManagedConnection managedConnection) {
-            ManagedChildProcessConnection connection = managedConnection.mConnection;
-            if (connection.isSandboxed()) {
-                managedConnection.addModerateBinding();
-                if (connection.isModerateBindingBound()) {
-                    addConnectionImpl(managedConnection);
-                } else {
-                    removeConnectionImpl(managedConnection);
-                }
+            managedConnection.addModerateBinding();
+            if (managedConnection.mConnection.isModerateBindingBound()) {
+                addConnectionImpl(managedConnection);
+            } else {
+                removeConnectionImpl(managedConnection);

[boliu, 2017/05/08 16:35:04]

existing code, but I think else block can never happen?

[Jay Civelli, 2017/05/08 17:09:27]

If we fail to bind the moderate binding, I believe the else block will be run.
But I am not sure if that makes any sense.
I'll clean that up as a follow up CL (filed
https://bugs.chromium.org/p/chromium/issues/detail?id=719575 for it).

             }
         }
 
         void removeConnection(ManagedConnection managedConnection) {
-            if (managedConnection.mConnection.isSandboxed()) {
-                removeConnectionImpl(managedConnection);
-            }
+            removeConnectionImpl(managedConnection);
         }
 
         void removeAllConnections() {