Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1783)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ImportantChildProcessConnection.java

Issue 2863063002: Making ChildConnectionAllocator simpler. (Closed)
Patch Set: Fixed tests. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/ImportantChildProcessConnection.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/ImportantChildProcessConnection.java b/content/public/android/java/src/org/chromium/content/browser/ImportantChildProcessConnection.java
index 1e50178236670290a1af2c7c7ad2a0aa0f08dfb5..700f00afca358c1078a10cbc9f2523a49e8c956d 100644
--- a/content/public/android/java/src/org/chromium/content/browser/ImportantChildProcessConnection.java
+++ b/content/public/android/java/src/org/chromium/content/browser/ImportantChildProcessConnection.java
@@ -16,20 +16,20 @@ import org.chromium.base.process_launcher.ChildProcessCreationParams;
public class ImportantChildProcessConnection extends BaseChildProcessConnection {
public static final Factory FACTORY = new BaseChildProcessConnection.Factory() {
@Override
- public BaseChildProcessConnection create(Context context, boolean sandboxed,
- DeathCallback deathCallback, String serviceClassName,
- Bundle childProcessCommonParameters, ChildProcessCreationParams creationParams) {
- return new ImportantChildProcessConnection(context, sandboxed, deathCallback,
- serviceClassName, childProcessCommonParameters, creationParams);
+ public BaseChildProcessConnection create(Context context, DeathCallback deathCallback,
+ String serviceClassName, Bundle childProcessCommonParameters,
+ ChildProcessCreationParams creationParams) {
+ return new ImportantChildProcessConnection(context, deathCallback, serviceClassName,
+ childProcessCommonParameters, creationParams);
}
};
private final ChildServiceConnection mBinding;
- private ImportantChildProcessConnection(Context context, boolean sandboxed,
- DeathCallback deathCallback, String serviceClassName,
- Bundle childProcessCommonParameters, ChildProcessCreationParams creationParams) {
- super(context, sandboxed, deathCallback, serviceClassName, childProcessCommonParameters,
+ private ImportantChildProcessConnection(Context context, DeathCallback deathCallback,
+ String serviceClassName, Bundle childProcessCommonParameters,
+ ChildProcessCreationParams creationParams) {
+ super(context, deathCallback, serviceClassName, childProcessCommonParameters,
creationParams);
int flags = Context.BIND_AUTO_CREATE | Context.BIND_IMPORTANT;
if (shouldBindAsExportedService()) {

Powered by Google App Engine
This is Rietveld 408576698