Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2863033002: [subresource_filter] Make placeholder strings untranslateable (Closed)

Created:
3 years, 7 months ago by Charlie Harrison
Modified:
3 years, 7 months ago
CC:
agrieve+watch_chromium.org, chromium-reviews, srahim+watch_chromium.org, srahim
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[subresource_filter] Make placeholder strings untranslateable These will never be shown to users. BUG=689992 Review-Url: https://codereview.chromium.org/2863033002 Cr-Commit-Position: refs/heads/master@{#469765} Committed: https://chromium.googlesource.com/chromium/src/+/48e975e533eaf4b951551df1ea01e90ab5930fd8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/android/java/strings/android_chrome_strings.grd View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Charlie Harrison
dtrainor: ptal at chrome/android rockot: ptal at chrome/app srahim: FYI
3 years, 7 months ago (2017-05-05 03:51:32 UTC) #4
Ken Rockot(use gerrit already)
lgtm
3 years, 7 months ago (2017-05-05 18:18:13 UTC) #7
David Trainor- moved to gerrit
chrome/android lgtm
3 years, 7 months ago (2017-05-05 20:16:13 UTC) #8
Charlie Harrison
Thanks folks
3 years, 7 months ago (2017-05-05 20:18:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2863033002/1
3 years, 7 months ago (2017-05-05 20:19:18 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-05 20:28:12 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/48e975e533eaf4b951551df1ea01...

Powered by Google App Engine
This is Rietveld 408576698