Remove use_selection_height usage in LayoutText

Remove use_selection_height usage in LayoutText

All calls to LayoutText::AbsoluteRectsForRange don't use use_selection_height,
so use_selection_height is removed from LayoutText::AbsoluteRectsForRange and
its callee functions.

BUG=691198
Review-Url: https://codereview.chromium.org/2863023003
Cr-Commit-Position: refs/heads/master@{#469921}
Committed: https://chromium.googlesource.com/chromium/src/+/ec747d5400f2930853e1f90c8365916393803606

[tanvir, 2017-05-05 13:24:43]

Description was changed from

==========
Remove use_selection_height usage in LayoutText

All calls to LayoutText::AbsoluteRectsForRange don't use use_selection_height,
so use_selection_height is removed from LayoutText::AbsoluteRectsForRange and
its callee functions.

BUG=691198
==========

to

==========
Remove use_selection_height usage in LayoutText

All calls to LayoutText::AbsoluteRectsForRange don't use use_selection_height,
so use_selection_height is removed from LayoutText::AbsoluteRectsForRange and
its callee functions.

BUG=691198
==========

[tanvir, 2017-05-05 13:24:44]

tanvir.rizvi@samsung.com changed reviewers:
+ shanmuga.m@samsung.com, srirama.m@samsung.com

[tanvir, 2017-05-05 13:57:35]

tanvir.rizvi@samsung.com changed reviewers:
+ xiaochengh@chromium.org

[tanvir, 2017-05-05 13:57:35]

PTAL!!! Thanks

[Srirama, 2017-05-05 14:05:27]

https://codereview.chromium.org/2863023003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutText.cpp (right):

https://codereview.chromium.org/2863023003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutText.cpp:350: // Change the height
and y position (or width and x for vertical text)
correct indentation

[tanvir, 2017-05-05 14:15:12]

On 2017/05/05 14:05:27, Srirama wrote:
>
https://codereview.chromium.org/2863023003/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/layout/LayoutText.cpp (right):
> 
>
https://codereview.chromium.org/2863023003/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/layout/LayoutText.cpp:350: // Change the height
> and y position (or width and x for vertical text)
> correct indentation

Done. PTAL!!!

[Srirama, 2017-05-05 14:35:56]

Looks fine to me.

[Xiaocheng, 2017-05-05 17:08:58]

xiaochengh@chromium.org changed reviewers:
+ eae@chromium.org

[Xiaocheng, 2017-05-05 17:08:59]

+eae

lgtm

[eae, 2017-05-05 17:22:25]

Nice, thank you!

LGTM

[eae, 2017-05-05 17:48:21]

The CQ bit was checked by eae@chromium.org

[commit-bot: I haz the power, 2017-05-05 17:48:51]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-05 19:52:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-05 19:52:55]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[tanvir, 2017-05-08 06:21:31]

The CQ bit was checked by tanvir.rizvi@samsung.com

[commit-bot: I haz the power, 2017-05-08 06:22:07]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 08:17:32]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494224491990480,
"parent_rev": "60a6ebd54a2ab983980775cab24ac9d89cfab27d", "commit_rev":
"ec747d5400f2930853e1f90c8365916393803606"}

[commit-bot: I haz the power, 2017-05-08 08:18:15]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494224491990480,
"parent_rev": "60a6ebd54a2ab983980775cab24ac9d89cfab27d", "commit_rev":
"ec747d5400f2930853e1f90c8365916393803606"}

[commit-bot: I haz the power, 2017-05-08 08:18:17]

Description was changed from

==========
Remove use_selection_height usage in LayoutText

All calls to LayoutText::AbsoluteRectsForRange don't use use_selection_height,
so use_selection_height is removed from LayoutText::AbsoluteRectsForRange and
its callee functions.

BUG=691198
==========

to

==========
Remove use_selection_height usage in LayoutText

All calls to LayoutText::AbsoluteRectsForRange don't use use_selection_height,
so use_selection_height is removed from LayoutText::AbsoluteRectsForRange and
its callee functions.

BUG=691198

Review-Url: https://codereview.chromium.org/2863023003
Cr-Commit-Position: refs/heads/master@{#469921}
Committed:
https://chromium.googlesource.com/chromium/src/+/ec747d5400f2930853e1f90c8365...
==========

[commit-bot: I haz the power, 2017-05-08 08:18:18]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/ec747d5400f2930853e1f90c8365...